muriloventuroso / givemelyrics Goto Github PK

Here is a screenshot:

Actually the app name is translated but not the summary and description. I don't know why I didn't found the issue.

The extra translations (like in appdata.xml) aren't implemented yet, or there is just something wrong and the translations aren't displaying in the AppCenter.

Hi there,
I tried donating, but your paypal link seems broken!

Hi Murilo, I saw you're looking for new sources. I have a python dbus service for this on my app Lyrics, the interesting part is that I scrapped that from osdlyrics, so I already have support for ViewLyrics, lrc123(which don't seems to work anymore), xiami, and netease lyric repositories. But the weird part is that it's very outdated code and I don't want to spend time on fixing anything there. I think in the long run the best thing that can be made is to setup a server ourselves(I had been flerting with the idea of a a P2P solution, which also leave me free of a legal problem, but IDK about the complexity of this), maybe joinning efforts with osdlyrics and provide a service for our three apps.

Their API aren't public I think so you will need to figure out by looking at the source.

The application crashes after a while, I don't know exactly why, but it seems to happen when the application is not in the foreground (without focus).

As previously referenced in #20 the "Loading..." message doesn't appear anymore between songs. It's just stuck like 5 seconds on the previous song (or ad), even if synchronized lyrics are disabled.

Hello.

You see, since sometimes Give Me Lyrics can't find the lyrics on the Internet, what I do is manually tag the lyrics into the mp3 file. So I would like to know if it's possible to implement that Give Me Lyrics can be able to read the lyrics from the file's metadata like Cantata does.

Thanks.

Would be cool if we can play and pause or music in the same place we read their lyrics.

on GNOME, the application is transparent (see the screenshot below).

Changing $bg_color to $theme_bg_color in the css fixes the issue but I don't know if it would apply on elementary.

Depending on the lyrics provider, this might not be possible, however, I think it would be cool if you can add this feature :

It doesn't have to be super sophisticated. Just need to show verse 1, 2, 3, and Chorus.

Here is the output I have with a segmentation fault:

com.github.muriloventuroso.givemelyrics 

(com.github.muriloventuroso.givemelyrics:14937): Gtk-CRITICAL **: 13:19:03.393: gtk_widget_insert_action_group: assertion 'GTK_IS_WIDGET (widget)' failed
null:363: element svg: validity error : ID wds-icons-dropdown-tiny already defined
ds-icon wds-icon-tiny wds-dropdown__toggle-chevron" id="wds-icons-dropdown-tiny"
                                                                               ^
:363: element path: validity error : ID dropdown-tiny-a already defined
9,8.56564348 C6.4097934,8.72164496 6.20499145,8.80004571 6.0001895,8.80004571 Z"
                                                                               ^
:472: element svg: validity error : ID wds-icons-dropdown-tiny already defined
ds-icon wds-icon-tiny wds-dropdown__toggle-chevron" id="wds-icons-dropdown-tiny"
                                                                               ^
:472: element path: validity error : ID dropdown-tiny-a already defined
9,8.56564348 C6.4097934,8.72164496 6.20499145,8.80004571 6.0001895,8.80004571 Z"
                                                                               ^
:536: element svg: validity error : ID wds-icons-dropdown-tiny already defined
ds-icon wds-icon-tiny wds-dropdown__toggle-chevron" id="wds-icons-dropdown-tiny"
                                                                               ^
:536: element path: validity error : ID dropdown-tiny-a already defined
9,8.56564348 C6.4097934,8.72164496 6.20499145,8.80004571 6.0001895,8.80004571 Z"
                                                                               ^
:545: element svg: validity error : ID wds-icons-menu-control-tiny already defined
s="wds-icon wds-icon-tiny wds-dropdown-chevron" id="wds-icons-menu-control-tiny"
                                                                               ^
:577: element svg: validity error : ID wds-icons-menu-control-tiny already defined
s="wds-icon wds-icon-tiny wds-dropdown-chevron" id="wds-icons-menu-control-tiny"
                                                                               ^
:609: element svg: validity error : ID wds-icons-menu-control-tiny already defined
s="wds-icon wds-icon-tiny wds-dropdown-chevron" id="wds-icons-menu-control-tiny"
                                                                               ^
:641: element svg: validity error : ID wds-icons-menu-control-tiny already defined
s="wds-icon wds-icon-tiny wds-dropdown-chevron" id="wds-icons-menu-control-tiny"
                                                                               ^
:710: element svg: validity error : ID wds-icons-dropdown-tiny already defined
ds-icon wds-icon-tiny wds-dropdown__toggle-chevron" id="wds-icons-dropdown-tiny"
                                                                               ^
:710: element path: validity error : ID dropdown-tiny-a already defined
9,8.56564348 C6.4097934,8.72164496 6.20499145,8.80004571 6.0001895,8.80004571 Z"
                                                                               ^
:725: element svg: validity error : ID wds-icons-menu-control-tiny already defined
s="wds-icon wds-icon-tiny wds-dropdown-chevron" id="wds-icons-menu-control-tiny"
                                                                               ^
:757: element svg: validity error : ID wds-icons-menu-control-tiny already defined
s="wds-icon wds-icon-tiny wds-dropdown-chevron" id="wds-icons-menu-control-tiny"
                                                                               ^
:790: element svg: validity error : ID wds-icons-dropdown-tiny already defined
ds-icon wds-icon-tiny wds-dropdown__toggle-chevron" id="wds-icons-dropdown-tiny"
                                                                               ^
:790: element path: validity error : ID dropdown-tiny-a already defined
9,8.56564348 C6.4097934,8.72164496 6.20499145,8.80004571 6.0001895,8.80004571 Z"
                                                                               ^
:811: element svg: validity error : ID wds-icons-menu-control-tiny already defined
s="wds-icon wds-icon-tiny wds-dropdown-chevron" id="wds-icons-menu-control-tiny"
                                                                               ^
:845: element svg: validity error : ID wds-icons-dropdown-tiny already defined
ds-icon wds-icon-tiny wds-dropdown__toggle-chevron" id="wds-icons-dropdown-tiny"
                                                                               ^
:845: element path: validity error : ID dropdown-tiny-a already defined
9,8.56564348 C6.4097934,8.72164496 6.20499145,8.80004571 6.0001895,8.80004571 Z"
                                                                               ^
:938: element svg: validity error : ID wds-icons-dropdown-tiny already defined
ds-icon wds-icon-tiny wds-dropdown__toggle-chevron" id="wds-icons-dropdown-tiny"
                                                                               ^
:938: element path: validity error : ID dropdown-tiny-a already defined
9,8.56564348 C6.4097934,8.72164496 6.20499145,8.80004571 6.0001895,8.80004571 Z"
                                                                               ^
:1291: element svg: validity error : ID wds-company-logo-fandom-white already defined
r__header-logo" alt="Fandom powered by Wikia" id="wds-company-logo-fandom-white"
                                                                               ^

(com.github.muriloventuroso.givemelyrics:14937): Gtk-CRITICAL **: 13:19:06.063: _gtk_css_ident_value_get: assertion 'value->class == &GTK_CSS_VALUE_IDENT' failed

(com.github.muriloventuroso.givemelyrics:14937): Gtk-CRITICAL **: 13:19:06.063: _gtk_css_ident_value_get: assertion 'value->class == &GTK_CSS_VALUE_IDENT' failed

(com.github.muriloventuroso.givemelyrics:14937): GLib-CRITICAL **: 13:19:06.063: g_ascii_strcasecmp: assertion 's1 != NULL' failed

(com.github.muriloventuroso.givemelyrics:14937): GLib-CRITICAL **: 13:19:06.063: g_ascii_strcasecmp: assertion 's1 != NULL' failed
Erreur de segmentation

It happened after an advertisment when playing bad guy (with Justin Bieber) from Billie Eilish.

I listen to spotify, the apps usually picked a different verse that has similar sentences (you know songs nowadays that repeats lyrics and only tweaking it for the next verse instead of writing a new one). Any possibility to fix that or is this just imperfection because spotify is closed source?

In the new version of AppCenter Dashboard, we're no longer modifying your appdata before publishing, so you'll need to add your stripe key to appdata.xml under the key x-appcenter-stripe to continue to monetize your app in elementary OS 6

For your convenience, your public stripe key is:
<value key="x-appcenter-stripe">pk_live_5jQXnM9vRslDM8gVpuV1S0b9</value>

It says easy ssh. A quick one to correct😉

Spotify does this on their apps, be it native, flatpak, or snaps. I don't know if you can do it, but it would be great if you can :)

It may help people to download the app if it's description on the AppCenter is translated too.
Just add com.github.muriloventuroso.givemelyrics.appdata.xml.in to translation files.

I don't know what their source is, but it finds (synchronized)lyrics of most songs in my library.
They are open-source too.

It's currently still on 2.2

https://www.flathub.org/apps/details/com.github.muriloventuroso.givemelyrics

Lyrics, I assume, are very difficult to find. I'd say the top inspiration on how it should be done comes from Guayadeque...though it's old and not maintained...

However, it does the best job of finding lyrics. I use 'Songrec' to get the title/album etc of tracks (regardless of gibberish tags).
Then in the Lyrics window, a search often works. If not, there's a friendly button to 'search' which opens 'Google Lyrics %taginfo' which mostly works - copy the lyrics and click to edit in Guayadeque and paste.

These lyrics are then embedded in the file. They still don't work with 'givemelyrics' sadly (or a great many other players).

Sometimes wrong lyrics are displayed instead of "No lyrics found". I think it's due to Letras.

For example if the song is "Control - Feder" the link is https://www.letras.mus.br/feder/control/

But Letras has no match with this one so it redirects to an other song of the same artist. In my example the link is changed to https://www.letras.mus.br/feder/breathe/ which is the song "Breathe - Feder"

Maybe you can try to check if the URL you send is the same as interpreted by Letras. If it's not the case, you can display "No lyrics found" instead of wrong lyrics.

Thanks for your submission to AppCenter! However, during review we noticed an inaccuracy in your OARS content rating metadata: social-info is set to none, but your app connects to an online API. This means the level should be at least mild, depending on the amount of data sent.

Please resolve this issue and then submit a new release to AppCenter.

I've used another lyrics app and what i enjoyed about it is the ability to download lyrics so you can access them even when offline i wish same it was with this one.
just a suggestion.

It wouldn't open any windows. Several second later, it will show a window taht said the app hasn't respond. It will give us option to either wait or force quit.

As you might have heard, AppCenter is going Flatpak! For elementary OS 6, we will not longer be accepting Debian packaging, so your app will need to be updated.

We have documentation on our developer guide for writing your Flatpak manifest here: https://docs.elementary.io/develop/writing-apps/our-first-app/packaging#flatpak-manifest

Also, in case you missed it, elementary OS 6 beta 2 is now available. This is a great time to get your app packaged up as Flatpak and test that everything is working before the final release. AppCenter submission for OS 6 will be open soon, so don't delay :)

I get the "Nothing is playing" warning every time I open the program when listening in Melody by Artem Anufrij (2.2.0).

I've tried with multiple songs, all well known.

Also I get this warning when opening in terminal: (com.github.muriloventuroso.givemelyrics:19382): Gtk-CRITICAL **: 23:56:55.557: gtk_box_pack: assertion '_gtk_widget_get_parent (child) == NULL' failed, it might not be related to the first problem.

Good morning! This app is not available in the ElementaryOS App Store... Please bring it to ElementaryOS. Why do we miss it!

Since last update the app takes more time to fetch the lyrics. This have an impact on synchronized lyrics which doesn't start at the beginning of the song.

Also "Loading..." doesn't appear anymore between songs. It's just stuck like 5 seconds on the previous song (or ad).

AppCenter ran a bunch of tests on your appstream file. These are the results.

Warnings:

Most of these are fixed during the building process, but you should ensure they
are fixed in your code for future releases.

• "id" field should be "com.github.muriloventuroso.givemelyrics"

For more information, see:

• The AppStream Quickstart Guide
• The AppStream Metadata Specification

Build Information

Affects Architecture: amd64
Affects Distribution: juno
Built with the following references:

• refs/tags/0.1.0

Here is the song:

And here is what is displayed on Give Me Lyrics:

However, it's correctly displayed in the sound panel:

I think this may be due to the "-"

App crashes whenever any right click menu is open and it loading the lyrics. Replicable by right clicking the title bar of the app when it is loading lyrics.

Maybe you should add a margin at the bottom on the window. It's looking a little strange that the scrolling bar is reaching the bottom of the screen I think.

Here is a screenshot:

Same for the lyrics:

I thought that the source link will add the copyright of the song source like:

© Artist label, year

And all of this as a link

Also I thought that it will not be always visible, but added at the end of the lyrics when scrolling, not at the bottom of the window.

This makes it look ugly and IMO shouldn't happen.

I think that fixing #19 was too strict. Because some songs have no lyrics displayed. But lyrics were here before, and they are on Letras. Maybe you have to review how you actually check the lyrics match with Letras.

I had this issue with the song "Heroes" from "Måns Zelmerlöw" (maybe due to the accents? Idk).

Hi I've just finished translation to Korean, found this project left behind with out finished.

As I have a bit of translating experience, I've opened this issue to tell something before requesting translation from your script. This would apply to any other languages.

1. Please add some annotations for few words or short sentences because in some case, words translating to other languages could make misunderstandings. Like similar words that have common meanings but used in other ways.

2. For translating simple commands like yours 11th : Fix scroll window. It quite annoying because there's possibility that other words followed by. Like in this case : Fix scroll window (as ...
   ) and need to imagine what or how is this going to be used.

Something that exists in Fondo would be nice.

Here is a screenshot:

Maybe it would be a good thing to credit the lyrics provider in small text after these depending on the source.

Maybe it might be useful to display "Advertising" instead of "No lyric found" when the application detects, for example for Spotify that the song title is "Spotify" or "Advertissement".

The new icon only appear on the app page in the AppCenter, not in the Application Menu and not in the Dock or everywhere else. Is it normal ?

Hi, I really appreciate your work , is a very good application
but i don't use elementary OS
could you make a flatpak for givemelyrics?
in this way, users can install the application in any linux distribution

please.
thank you.

App log

$ com.github.muriloventuroso.givemelyrics
load settings
I guess something is not working...

Network capture

$ curl -H "Host: music.163.com" --compressed "http://music.163.com/api/search/pc?offset=0&limit=1&type=1&s=(mymusic)"

{
	"code": -462,
	"data": {
		"actionCode": "1056401",
		"verifyType": 50,
		"verifyId": 1008601,
		"verifyUrl": "",
		"blockText": "绑定手机后，可进行下一步操作哦~",
		"verifyToken": null,
		"btnText": "",
		"orpheusUrl": "",
		"params": {
			"event_id": "(some_dec_numbers)",
			"sign": "(some_hex_numbers)"
		},
		"url": null
	},
	"message": "请绑定手机后再试哦~"
}

I played "The Satanist -- Behemoth" from Spotify and the app showed me lyrics for "Blow Your Trumpets Gabriel -- Behemoth" instead. Also, no lyrics are found for any song in the album "Communion" by Septicflesh.

May be fixed through adding more sources?