mvaerle / python-ifc Goto Github PK

python-ifc is an interesting project, i really like it, and it saves me much time.

But the python performance is low, loading a large file (~ 10M) takes 50 seconds, is there any possibility to improve it?

Also as I knew, there are some tools to do that, e.g. pypy, python, etc. Is there any possibility to translate this project to cython ? thanks.

it's a little easier to use this if values are returned as ints:

ie. line 39 ids.append(e["id"])

to

ie. line 39 ids.append( int(e["id"]) )

seems line 38 of ifcfilereader.py

ids = e.get(e["name"],[])

should read

ids = entsByName.get(e["name"],[])

just saying...

Can you slap a license on this code please? I've forked your repo and would like to know what I am allowed to do with the code. Anything standard like Apache 2 or GPL is great. :)

mvaerle,
Thanks for kicking off this effort, I see good things happening in the BIM world opening up through Python.
I am new to Python so I am slowly getting my way through the file slowly, and the three comments I have are:

• I would add a self.file.close() around line 21, unless I am missing it somewhere else
• I don't understand why you define the dictionaries in lines 12/13 (and again in 32/33)
• Is there a reason for entById and entsByName not being both singular/plural? Would it be better to unify them?

Again, kudos and thanks, I don't want to mess your code but if I would like to contribute as I gain confidence in Python.

Kind regards,
William.

Heads up for those interested, schema attribute assertion fails for python 3 (ifcfilereader.py:~76) suppose this is a regex flag problem as it seems very greedy for PY3..

PYTHON 2

[('GlobalId', 'IfcGloballyUniqueId'), ('OwnerHistory', 'IfcOwnerHistory'), ('Name', 'OPTIONAL IfcLabel'), ('Description', 'OPTIONAL IfcText'), ('ObjectType', 'OPTIONAL IfcLabel'), ('LongName', 'OPTIONAL IfcLabel'), ('Phase', 'OPTIONAL IfcLabel'), ('RepresentationContexts', 'SET [1:?] OF IfcRepresentationContext'), ('UnitsInContext', 'IfcUnitAssignment')]

PYTHON 3

[('\n\tGlobalId', 'IfcGloballyUniqueId'), ('\n\tOwnerHistory', 'IfcOwnerHistory'), ('\n\tName', 'OPTIONAL IfcLabel'), ('\n\tDescription', 'OPTIONAL IfcText'), ('\n UNIQUE\n\tUR1', 'GlobalId'), ('\n INVERSE\n\tHasAssignments', 'SET [0:?] OF IfcRelAssigns FOR RelatedObjects'), ('\n\tIsDecomposedBy', 'SET [0:?] OF IfcRelDecomposes FOR RelatingObject'), ('\n\tDecomposes', 'SET [0:1] OF IfcRelDecomposes FOR RelatedObjects'), ('\n\tHasAssociations', 'SET [0:?] OF IfcRelAssociates FOR RelatedObjects'), ('\n\tObjectType', 'OPTIONAL IfcLabel'), ('\n INVERSE\n\tIsDefinedBy', 'SET [0:?] OF IfcRelDefines FOR RelatedObjects'), ('\n WHERE\n\tWR1', "SIZEOF(QUERY(temp <* IsDefinedBy | 'IFC2X3.IFCRELDEFINESBYTYPE' IN TYPEOF(temp))) <= 1"), ('\n\tLongName', 'OPTIONAL IfcLabel'), ('\n\tPhase', 'OPTIONAL IfcLabel'), ('\n\tRepresentationContexts', 'SET [1:?] OF IfcRepresentationContext'), ('\n\tUnitsInContext', 'IfcUnitAssignment'), ('\n WHERE\n\tWR31', 'EXISTS(SELF\IfcRoot.Name)'), ('\n\tWR32', "SIZEOF(QUERY(Temp <* RepresentationContexts |\n 'IFC2X3.IFCGEOMETRICREPRESENTATIONSUBCONTEXT' IN TYPEOF(Temp)\n )) = 0"), ('\n\tWR33', 'SIZEOF(SELF\IfcObjectDefinition.Decomposes) = 0')]

When I try to run "ifcfreecad.py" It returns error ImportError: No module named FreeCADGui