mverissimo / emotion-grid Goto Github PK
View Code? Open in Web Editor NEWA responsive (mobile-first) grid system built with emotion.
Home Page: https://emotion-grid.netlify.app/
License: MIT License
A responsive (mobile-first) grid system built with emotion.
Home Page: https://emotion-grid.netlify.app/
License: MIT License
Hi,
I tried to change the breakpoints in the config and it doesn't seem to work. I provided a theme just like in the example and all options seem to work as intended except the breakpoints.
const theme = {
grid: {
container: {
xs: 'full',
sm: 'full',
md: 45,
lg: 60,
xl: 200,
},
...
breakpoints: {
xs: 1,
sm: 33.75,
md: 42,
lg: 54,
xl: 187.5,
}
},
}
const Layout = ({ children }: LayoutProps) => {
return (
<ThemeProvider theme={theme}>
<Global styles={styling()} />
{children}
</ThemeProvider>
)
}
The values don't make sense but container.xl works, padding etc works too. grid.breakpoints.xl doesn't change the media query for that breakpoint. I dug around a little and found the following line of code:
emotion-grid/src/utils/media.ts
Line 8 in d41431d
It seems like config() is called without the theme and therefore it uses the defaults.
Is this behaviour intended? It doesn't make sense to me. Would be happy to hear from you.
alpha
branch failed. π¨I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.
You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. Iβm sure you can resolve this πͺ.
Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.
Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the alpha
branch. You can also manually restart the failed CI job that runs semantic-release.
If you are not sure how to resolve this, here is some links that can help you:
If those donβt help, or if this issue is reporting something you think isnβt right, you can always ask the humans behind semantic-release.
An npm token must be created and set in the NPM_TOKEN
environment variable on your CI environment.
Please make sure to create an npm token and to set it in the NPM_TOKEN
environment variable on your CI environment. The token must allow to publish to the registry https://registry.npmjs.org/
.
Good luck with your project β¨
Your semantic-release bot π¦π
Hi,
The link for the contributing guide in the main README.md file is taking me to https://google.com instead of an actual guide. I am not sure if this was intended.
Thanks,
Felipe
After some reviews using rem as a unit, I found some minor bugs when calc, look below:
I have the following values(rem) for padding/gutter:
1.875 = 30px
0.938 = 15px
When a tried to subtract by 2, I get this result:
1.875 / 2 = 0.9375
Yes, this is equivalent to 15px, but this minor difference 0.00049
create a gap of 1/2px on container width, look:
master
branch failed. π¨I recommend you give this issue a high priority, so other packages depending on you could benefit from your bug fixes and new features.
You can find below the list of errors reported by semantic-release. Each one of them has to be resolved in order to automatically publish your package. Iβm sure you can resolve this πͺ.
Errors are usually caused by a misconfiguration or an authentication problem. With each error reported below you will find explanation and guidance to help you to resolve it.
Once all the errors are resolved, semantic-release will release your package the next time you push a commit to the master
branch. You can also manually restart the failed CI job that runs semantic-release.
If you are not sure how to resolve this, here is some links that can help you:
If those donβt help, or if this issue is reporting something you think isnβt right, you can always ask the humans behind semantic-release.
The npm token configured in the NPM_TOKEN
environment variable must be a valid token allowing to publish to the registry https://registry.npmjs.org/
.
If you are using Two-Factor Authentication, make configure the auth-only
level is supported. semantic-release cannot publish with the default auth-and-writes
level.
Please make sure to set the NPM_TOKEN
environment variable in your CI with the exact value of the npm token.
Good luck with your project β¨
Your semantic-release bot π¦π
A declarative, efficient, and flexible JavaScript library for building user interfaces.
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. πππ
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google β€οΈ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.