mwdelaney / bootstrap-3-shortcodes

WordPress shortcodes for easier use of Bootstrap elements in your content.

Hi there 👋

I'm Michael and I'm a web developer; he/him.

https://michaeldelaney.me

bootstrap-3-shortcodes's Issues

Add buttons to editor

Nice one, but you should add buttons to visual editor so user can insert those stuff from buttons, and don't need to remember code.

Offset

Hi,

I have problems setting offset parameter, i set the shortcode like this:

[column lg="5" offset-lg="1"]Content[/column]

And this return:

<div class="col-lg-5 ">Content></div>

Its not returning the offset parameter or am i doing something wrong?

Thanks.

Merge conflict

Hola,

Thanks for merging the PR but you have merge conflicts:

https://github.com/filipstefansson/bootstrap-shortcodes/blob/db0fd97b7a05b2b013777979b5936d56694eef3f/bootstrap-shortcodes.php#L330

Best way now is to fix them manually. Next time maybe merge the PR local and not directly online?

Progress Bars

Add support for Progress Bars (http://getbootstrap.com/components/#progress)

Page don't load with ACF

Hi,

I am been using ACF with B3S without any issues but know B3S is causing some problems with page loading in the wp-admin, if the page i am editing has custom fields (using ACF) the page don't full load.

I checked the source-code an i get this error:

<b>Warning</b>:  require(php_markdown//WP/Editors.php) [<a href='function.require'>function.require</a>]: failed to open stream: No such file or directory in <b>public_html/wp-content/plugins/bootstrap-3-shortcodes/includes/bootstrap-shortcodes-help.php</b> on line <b>15</b>
<b>Warning</b>:  require(php_markdown//WP/Editors.php) [<a href='function.require'>function.require</a>]: failed to open stream: No such file or directory in <b>public_html/wp-content/plugins/bootstrap-3-shortcodes/includes/bootstrap-shortcodes-help.php</b> on line <b>15</b><br />
<b>Fatal error</b>:  require() [<a href='function.require'>function.require</a>]: Failed opening required 'php_markdown//WP/Editors.php' (include_path='.:/usr/lib/php:/usr/local/lib/php') in <b>public_html/wp-content/plugins/bootstrap-3-shortcodes/includes/bootstrap-shortcodes-help.php</b> on line <b>15</b>

Can you check what is wrong?

Thanks again.

Error DomDocument

Hi, using php 5.4 I get an error on the table_wrap shortcode:

Call to a member function setAttribute() on a non-object

This is on line:

$dom->documentElement->setAttribute('class', $dom->documentElement->getAttribute('class') . ' ' . esc_attr( $class ));

Thanks
Regards

Breadcrumbs

Add support for Breadcrumbs (http://getbootstrap.com/components/#breadcrumbs)

Is the php_markdown submodule necessary?

The framework is included in the Michelf-folder, so why add it as a git submodule as well?

We should pick one. Including the framework would be easier for the average user, compared to using the submodule.

Undefined variable: context in ../includes/actions-filters.php on line 25

Notice: Undefined variable: context in /var/www/demo.nextgenthemes.com/htdocs/wp-content/plugins/bootstrap-3-shortcodes/includes/actions-filters.php on line 25

Appears in my admin below the 'Add Media' btn.

Running Ubuntu 13.10 with current official Apache+PHP with xdebug enabled.

Bootstrap Shortcodes Help

Whenever I click the "Bootstrap Shortcodes Help" button it pulls up a blank iframe.

Classes inside [carousel] get deleted.

Hi,

I don't know why, but it seems that all classes within the [carousel] shortcode don't make it into the final site. It doesn't matter if they're applied to a div, p, img ...

E.g.:

[carousel]
[carousel-item active="true"]
<div class="test">
Lorem ipsum dolor sit amet, 
consectetur adipisicing elit. Quod, temporibus officiis 
veniam ducimus obcaecati sed.
</div>
[/carousel-item]
[carousel-item] … [/carousel-item]
[carousel-item] … [/carousel-item]
[/carousel]

Any ideas how to work around that?

Nested shortcodes

It would be great if the [row] and [column] shortcodes could be nested. So to bypass the Wordpress way of handling shortcodes, something should be added to the name. Like [subrow] or [row1] [row2]. Or any other clever idea?

Support new features in Bootstrap 3.1.0

Oh jeez.

http://blog.getbootstrap.com/2014/01/30/bootstrap-3-1-0-released/

Add Class to Grid

Hi,

It's not possible to add a custom class to grid shortcode? Something like:

[column lg="5" offset_lg="1" class="custom-class-1 custom-class-2"]

Thanks.

Drop table shortcode

I think we should consider dropping the [table] shortcode. Tables aren't natively supported in the WordPress editor, so the inclusion of [table] in this plugin sort of goes beyond the scope of supporting Bootstrap via shortcodes.

Error: DOMDocument::loadXML()

I'm trying to integrate the shortcodes inside my theme
but I got this error when using the Popover or the Tooltip

Warning: DOMDocument::loadXML(): Start tag expected, '<' not found in Entity, line: 1 on admin\shortcodes\shortcodes.php on line 655

Any help?

Notice: Undefined index - Tabs

I get this issue while trying to use the tabs

Notice: Undefined index: active in C:\Users\Matthew\Discotoast\Dev\dtwp\framework\wp-content\plugins\bootstrap-3-shortcodes\bootstrap-shortcodes.php on line 1198

Uncaught TypeErrors

When viewing the console I get the following errors.

Uncaught TypeError: Object [object Object] has no method 'tooltip

Uncaught TypeError: Object [object Object] has no method 'popover'

This causes errors to pop up in IE.

You can view the errors here (this is a clean build using the latest version of WP and this plugin. I have tested both 2012 and 2013 to make sure it was not a theme conflict).

http://playground.bldsvr.com/

p.s. php_markdown is not being included in the master download using the download zip feature of github. I'm not sure what the issue is there.

Undefined variable: data_props

Hi,

With this shortcode:

[button type="success" size="lg" link="#"] test [/button]

...I've got this notice:

Notice: Undefined variable: data_props in /home/(...)/bootstrap-shortcodes.php on line 132

thanx.

Notices everywhere

Hello

you are often using this

     $return .= ($data_props) ? ' ' . $data_props : '';

If no data_props is set we get many "notice" in logs. May be this would be better

$return .= (!empty($data_props)) ? ' ' . $data_props : '';

What do you think?

BR being added between shortcodes

The default output is adding breaks between content.

I have tried adding remove_filter('the_content','wpautop'); to my themes function file and it still is adding breaks.

Based on the shortcodes functions, it seems like this should not be happening.

I also disabled all other plugins and am not finding a conflict.

My output ends up looking like this -

<div class="row"><br>
<div class="col-md-6 "><br>
…<br>
</div><br>
<div class="col-md-6 "><br>
…<br>
</div><br>
</div>

Any ideas?

Trigger Tooltip and Popover with data-attributes rather than Javascript

Hello,

users of this plugin are using Bootstrap already so why don't removing tooltip.js and popover.js from the plugin?

If there is an option for doing it I haven't seen it and I am doing it directly in the code but it is not the best option because of plugin updates.

We are adding two more files to the code, two more request.

BR

Website for this plugin

@filipstefansson how do you feel about putting up a website, or even just a GitHub Page for this plugin? It might help us gain some more exposure, let us offer a .zip which includes the necessary submodules, etc. Thoughts?

Carousel

Add support for Carousel (http://getbootstrap.com/javascript/#carousel)

Improve Modals to use buttons and data pairs

Modals should enclose a [button] shortcode with data-pairs for more useful trigger links.

Collapse With Type Affects "Active"-State

Hi there,

I'm really liking the looks of this, nice work! :-)

However, if you create a collapsible such as:

[collapse title="Collapse 1" active="true" type="primary"]
Text
[/collapse]

Then it will receive the class "inprimary" instead of "in primary". Therefore, it's not possible to create panels that are open by default when applying one of the styles (default, primary, warning, danger, etc.).

Best wishes,
ClientEngage

Add Button-Toolbar

Add support for Button Toolbar: http://getbootstrap.com/components/#btn-groups-toolbar

Undefined offset:1 in bootstrap-shortcodes.php on line 1972

Just downloaded and installed the newest bootstrap-shortcodes package. I'm running debug in WordPress and it issued this:

"Notice: Undefined offset: 1 in C:\xampp_clients\smindy\wp-content\themes\smindy2013\bootstrap-3-shortcodes-master\bootstrap-shortcodes.php on line 1972"

Looks like it is referring to this line of code:
$data_props .= sprintf( 'data-%s="%s" ', esc_html( $d[0] ), esc_attr( trim( $d[1] ) ) );

Better List Groups

Currently the [list-group] shortcode generates the list HTML. This is fine, but it should be updated to use DOMDocument to check for, and traverse TinyMCE-created HTML if present.

It should also be updated to allow for non "li" list items.

Button Dropdowns

Add support for Button Dropdowns (http://getbootstrap.com/components/#btn-dropdowns)

TinyMCE adds empty p tags in each and everyline while using [code] shortcode.

Solution:

//move wpautop filter to AFTER shortcode is processed
remove_filter( 'the_content', 'wpautop' );
add_filter( 'the_content', 'wpautop' , 99);
add_filter( 'the_content', 'shortcode_unautop',100 );

Issue on Activation

I receive this on activation:

Warning: include() [function.include]: Failed opening 'bootstrap-shortcodes-help.php' for inclusion (include_path='.:/usr/local/php-5.3.27/share/pear') in /nfs/c03/h01/mnt/51370/domains/themes.siiimple.com/html/alpha/wp-content/plugins/bootstrap-3-shortcodes-1/includes/actions-filters.php on line 36

Not sure if this is a known issue or not.

Thanks
Justin

PHP short tags - change <? to <?php

WARNING: Found PHP short tags in file includes/php_markdown/Michelf/Markdown.php.
Line 346: | # PHP and ASP-style processor instructions (<? and <%)

"Images" support

Add shortcode for Bootstrap "Images" (http://getbootstrap.com/css/#images) using DOMDocument to edit the tags of TinyMCE-inserted images.

Include true/false for also applying img-responsive class.

Possible to remove additional <br/>?

Hi,

first of all, superp plugin! Saved me tons of work, thanks so much!
I guess that's a general WordPress issue, but maybe the plugin can be optimized to avoid it:

When using the columns shortcode as in the readme:

[row]
  [column md="6"]
    …
  [/column]
  [column md="6"]
    …
  [/column]
[/row]

the second column starts one line below the first column. They're not vertically aligned. That somehow comes because WordPress inserts a BR after the shortcode. It can be avoided by having the shortcode and content on the same line

[column md="6"]   …[/column]

however that's not nearly as nice.

Thanks for your opinions!
Philipp

Table Type

Hi,

How can i remove the tablet type? If i write the shortcode like this (without type parameter):

[table cols="..." data="...."]

It will return:

<table class="table table-type table-bordered">

But i just need:

<table class="table">

How can i do it?

Thanks a lot.

Page Header

Might as well add Page Header, too, right?

Twitter_Boostrap_logo.svg not showing

Hi! Looks like the file action-filters.php can't access the $img variable which points to the bootstrap image, making this error on the admin page:
https://www.dropbox.com/s/utzox6gyoviphto/Screenshot%202014-02-06%2013.36.12.png

And a weird img src:
http://dev.mysite.com/wp/Users/myusername/Documents/Work/mysite/app/plugins/bootstrap-3-shortcodes/includes/images/Twitter_Boostrap_logo.svg

Is there a fix for this?

Syntax Errors - Host Gator

I installed this plugin on a site hosted on hostgator and am getting some odd issues.

Here is what I get -

Parse error: syntax error, unexpected T_STRING, expecting T_CONSTANT_ENCAPSED_STRING or '(' in /home/communit/public_html/wp-content/plugins/bootstrap-3-shortcodes/includes/bootstrap-shortcodes-help.php on line 24

Oddly this doesnt happen on my build server hosted with wiredtree. I'm not sure if there is a missing php module or what. Any ideas?

Submit to Wordpress.org Plugin Directory

If possible submit it to the Wordpress.org Plugin directory.

If you have already what is the URL for the plugin?

Nested Shortcode

Hi,

Is this possible? If yes, how can i do it? I tried but it doesn't execute the shortcode that is inside [responsive hide="xs"] for example.

Thanks.

Nav-Pills and Nav-Tabs

Add support for Navs (http://getbootstrap.com/components/#nav)

DOMDocument::loadXML()

Hi,

With last update (via wp-admin) i am getting a lot of:

Warning: DOMDocument::loadXML() [domdocument.loadxml]: Extra content at the end of the document in Entity....
wp-content/plugins/bootstrap-3-shortcodes/bootstrap-shortcodes.php on line 1145

What am i doing wrong?

Thanks.

Noticed a typo in repo description

Don't know if you care, but I'm sure this repo description typo was unintentional:

WordPress shortcodes for easier use of Bootstrap elements is your content.

Shotcode Gets Executed Inside [code]

So, I was trying to show shortcode example inside [code] shortcode. Something like this [code][button][/code]. I noticed that the [button] shortcode also gets execured and shows button html while it should only show the text version of [button] not executed html replacement.

Missing [container] shortcode

If I'm correct there is no [container] shortcode?

Would be great if you could add this one (with the possbility to add a custom class).

function bs_container( $atts, $content = null ) {
    extract(shortcode_atts(array(
      "custom" => false
    ), $atts));
    $classes = ($custom) ? ' '.$custom : '';    
    $return = '<div class="container'.$classes.'">' . do_shortcode( $content ) . '</div>';

    return $return;
}

Popover loadXML issue

When using popovers I am getting the following error.

Warning: DOMDocument::loadXML() [domdocument.loadxml]: Start tag expected, '<' not found in Entity, line: 1 in /home/bldsvr/public_html/comauto/wp-content/plugins/bootstrap-3-shortcodes/bootstrap-shortcodes.php on line 1265

Wordpress says there's a new plugin version available:

When I install this plugin WordPress tells me there's an update available for it, but it updates it to this plugin: https://github.com/TheWebShop/bootstrap-shortcodes

When I change the name of the plugin directory it doesn't give me the upgrade warning.

Maybe this plugin needs a new name to not conflict with similarly generic plugin names.

iFrame

Hello,

My page don't load if inside [responsive] shortcode i use an iframe.

Its not supported?

Thanks.

tooltip not working: "not a function" message.

Tooltip, using this shortcode, is not working:

[tooltip title="I'm the title" placement="left"]Hmmm, Tooltip[/tooltip]

I get the following error in the Firebug console:

TypeError: $(...).tooltip is not a function
$('.bs-tooltip').tooltip();

Which references line 2 of bootstrap-shorcodes-tooltip.js:

(function($) {
$('.bs-tooltip').tooltip();
})(jQuery);

(I am loading .../bootstrap/dist/js/bootstrap.min.js in the header of my theme, and all other shortcodes I have tested seem to work except this one and popover, which fails with a similar Firebug notice.)