my-cloud / ruthenium Goto Github PK

In GitLab by @Styks on Aug 2, 2022, 08:43

• Don't add in a new block the transactions from a sender wallet which have insufficient amount
• Make ResolveConflict not accepting a blockchain with transactions which could not have been performed (verify signature and amount)
• Propagate transactions pool
• Make ResolveConflict not accepting a blockchain with mining rewards exceeding the consented one
• Verify mining delay

For a first implementation, we taken the easy way. To know if someone is registered in the Proof of Humanity registry, we are requesting this REST API. This is a vulnerability because the data is centralized. We need to gather the information in a decentralized manner. To do so, we can directly read the isRegistered value from the Proof of Humanity smart contract.

• Directly read the Proof of Humanity smart contract isRegistered value

💡 Here is where the REST API is called in our code

💡 This seems to be a good tutorial to know how to read a smart contract

Context
Since the wallet amount is decreasing, people need a basic income to be interested in creating an account.
Since the validators need an incentive to add as much as transactions as possible into the next block, the reward must depend on transaction fees.

Description
The validator reward must be replaced by the transaction fees.
Every wallet must get a basic income.

Tasks

• Verify the Proof of Humanity for every wallet
• Give a basic income to every wallet that is registered
• Replace the actual reward calculation by the transaction fees

In GitLab by @Styks on Aug 25, 2022, 22:01

the go.mod module name points to the gitlab repository. Update it to reflect the github repository.

In GitLab by @Styks on Jul 27, 2022, 18:44

When the wallet address is empty in a request from wallet side, the blochain side logs error because of a nil pointer dereference.

• log it on wallet side only
• handle the case to not get a nil pointer dereference on blockchain side

• Verify that block transactions amounts does not exceed wallet amount

In GitLab by @Styks on Sep 11, 2022, 14:41

Since the semver is related to an API, it should be documented.

https://github.com/my-cloud/ruthenium/security/code-scanning/1

Context
A hudge transactions count might lead to a blockchain propagation time to out of the validation delay.

Description
The problem might be avoided by limiting the number of transactions to be included into the next block. Higher transactions fees might be applied to ensure a transaction to be in the next block.

Tasks

• Limit the block size or the number of transactions to be included into the next block.
• If needed, propose to pay more fees to increase the chance of a transaction to be in the next block.

In GitLab by @Styks on Aug 5, 2022, 12:49

Context
Verifying the whole blockchain might take more time as it grows up.

Description
A lot of time can be saved if the blockchain can be stored into a file to be loaded the next time the node is started.

Tasks
Try to split the feature into small tasks.

• Make it possible to store the blockchain into a file
• Make it possible to load the blockchain from a file

In GitLab by @Styks on Aug 8, 2022, 07:59

In GitLab by @Styks on Jul 22, 2022, 08:21

1. Only clear the transaction pool if a new block is validated
2. Remove DeleteTransactions from the blockchain API
3. Disallow start mining more than once

• Use broadcast messages to send to the client:
  • success or failure messages
  • message informing that the wallet amount has changed
  • message informing that the transactions pool has changed
• Do the appropriated treatment when receiving a message

💡see https://pkg.go.dev/context#Context.Done and use it here

In GitLab by @Styks on Jul 5, 2022, 14:23

In GitLab by @Styks on Aug 22, 2022, 15:23

Use PoH instead of PoW.

The default port is 8106 instead of 8080

• change the default port from 8106 to 8080

Context
Some of the constants defined in the project might have to be changed later on. It is a shame to modify source code to just change a setting.

Description
Most of the constants might be extracted to a configuration file

Tasks

• Extract constants into a configuration file.

We need to create a release branch

• edit the contributing file
• edit the docker-publish.yml
• add LABEL org.opencontainers.image.description DESCRIPTION in the Dockerfile

• add the following job in the quality workflow:

jobs:
  lint:
    name: Lint
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-go@v3
        with:
          go-version: 1.18
      - uses: golangci/golangci-lint-action@v3

In GitLab by @Styks on Aug 5, 2022, 17:58

There are calculus issues with floating points number find a way to only use unsigned integers.

• Improve the CONTRIBUTING.md file
• Link the CONTRIBUTING.md in the README.md

In GitLab by @Styks on Jul 22, 2022, 08:20

• Fix timeout error (read tcp 192.168.1.90:5000->192.168.1.90:62368: i/o timeout)
• Find neighbors only when needed
• Investigate about how is done the neighbor finding for famous blockchains and apply it

In GitLab by @Styks on Aug 8, 2022, 17:47

Since the ruthenium (106) is a radioelement, it should decay.

In GitLab by @Styks on Jul 26, 2022, 13:50

In GitLab by @Styks on Aug 8, 2022, 08:00

If there is no transaction fee, the blockchain network is vulnerable to transactions spam.

• Add transaction fee

When merging with rebase onto main, each commit is added individually, and their revision identifiers seem to differ from those of dev. To avoid conflicts for the next release, the release branch must be merged locally to main.

In GitLab by @Styks on Jul 27, 2022, 18:55

In GitLab by @Styks on Aug 5, 2022, 10:28

In GitLab by @gwenall on Aug 7, 2022, 18:01

• Create Dockerfile
• Create basic kuberenetes deployment manifests
• Create gitlab-ci

In GitLab by @Styks on Sep 7, 2022, 12:07

• Limit Outbound connections to 8
• Change the validation process:
  • Validate
  • Resolve conflicts every 10 seconds
  • Don't ask for consensus
• Remove consensus from the API

In GitLab by @Styks on Aug 4, 2022, 18:10

In GitLab by @Styks on Aug 2, 2022, 14:37

• Make the transaction be added to the pool only if the sender address correspond to the public key

• In the ruthenium/.github/workflows/docker-publish.yml file, remove the dev branch.

Instead of:

on:
  push:
    branches: [ "main", "dev" ]

We want:

on:
  push:
    branches: [ "main" ]

Investigate if it can be an issue (i.e. to find the oldest reward recipient) and if so, solve it by adding a rule to always have a single reward recipient

In GitLab by @Styks on Jul 13, 2022, 09:12

In GitLab by @Styks on Jul 22, 2022, 08:34