my-th-os / kml Goto Github PK

Specifically, uid of part in warning entry would allow searching within the savefile to the specific craft and part directly.
Maybe craft name would be nice but not necessary. For context I am only using the CLI mono version and only plan to use this version as it it can be driven by script with low overhead. So the request is for mono version. As far as I know the GUI version may already address this in another way.

Since 1.7.3, I've noticed a third parameter appearing in the sfrn parameter list in some modules. I believe it is some sort of collision model function.

Example: srfAttach, 80,COLLIDERADAPT

This is causing KML to not read the surface attachment node properly and causes incorrect parent node adjustments on node insert and delete. Attached is a zip file containing a modified KmlPart.cs that resolves the problem for me and a sample persistent.sfs file with a problematic ship in orbit around Kerbin.

submission.zip

The changes implemented include the following.

• a string variable AttachedToSurfaceCollider

• changes to the srfn processor code in the Add function to check for a third element in items[] and then processing the index value and copying the collider value to the AttachedToSurfaceCollider variable

• Changes to the srfn processor code in the ReIndexStructureForPartDeletion function to detect the third parameter and preserve it.

• Changes to the srfn processor code in the ReIndexStructureForPartInsertion function to detect the third parameter and preserve it.

These changes appear to work properly for my issues with the third parameter and for .sfs files that don't have the third parameter.

Hi, first of all thanks for your amazing Tool! It is very helpful in various situations.

However, for me, it would be even more helpful if part deletion were a thing. Is it possible to implement that?
What would be needed to do that? In your forum post, you mentioned:

parts (need to rebuild index numbers and attachments)

What exactly does this refer to? I understand the index numbers, but what do you mean about the attachments?
Also, could there be other issues that could arise from part deletion?

I might be able to help here, but I am unfamiliar with your code (although it looks very very clean, congrats on that ;) )

Since this is a .Net program, it should be fairly easy to limit it's subset of .Net routines in order to run on Linux and Mac, thus allowing just about anyone using KSP to run the program.

So fixing this by replacing any calls not support by Mono with those that can be would allow players on any platform to run this tool.