mylezeem / puppet-repoforge

A Puppet module that ensures the repoforge repo is installed

RPM Forge Puppet Module

This module aims to declare and enable rpm forge repositories

Usage

Simple Usage

include repoforge

Custom Usage

class {'repoforge' :
  enabled     => ['rpmforge', 'extras'],
  baseurl     => 'http://apt.sw.be/redhat/el6/en/${::architecture}',
  includepkgs => { 'extras' => 'memcached' },
  exclude     => { 'rpmforge' => 'nagios*', 'testing' => 'perl*' },
}

License

Apache License v2

Contact

Yanis Guenane - [email protected]

Support

Please log tickets and issues at our Projects site

puppet-repoforge's Issues

Always tries to import key on every puppet run

  class {'repoforge':
    enabled => ['rpmforge', 'extras'],
  }

[root(prod1)@cloud1 ~]# puppet agent -t
Info: Retrieving pluginfacts
Info: Retrieving plugin
Info: Loading facts
Info: Caching catalog for cloud1.example.com.au
Info: Applying configuration version '1460358569'
Notice: /Stage[main]/Repoforge/Repoforge::Rpm_gpg_key[RPM-GPG-KEY-rpmforge-dag]/Exec[import-RPM-GPG-KEY-rpmforge-dag]/returns: executed successfully
Notice: /Stage[main]/Puppetlabs_yum/Puppetlabs_yum::Rpm_gpg_key[RPM-GPG-KEY-puppetlabs]/Exec[import-RPM-GPG-KEY-puppetlabs]/returns: executed successfully
Notice: Finished catalog run in 2.80 seconds

Does this every single puppet run!

Need to add 'exclude' option to rpmforge.pp

Greetings,

For CentOS6, I need to exclude the following package as it has a conflict..
perl-XML-SAX-Base (conflicts with perl-XML-SAX in base).

I have added this manually to 'yumrepo.pp' and it works.
exclude => 'perl-XML-SAX-Base',
but it should probably be something that can be added to params.pp

(I am a puppet newbie.)

gpg key import exec check broken?

https://github.com/Mylezeem/puppet-repoforge/blob/f90996e6c7d98bb6ea80a616a2550e590262e605/manifests/rpm_gpg_key.pp
Line 26 - the unless condition
Actual outcome running puppet 3.7.3 on CentOS 7:
[root@zeus:~] # rpm -q gpg-pubkey-$(echo $(gpg --throw-keyids < /etc/pki/rpm-gpg/RPM-GPG-KEY-rpmforge-dag) | cut --characters=11-18 | tr [A-Z] [a-z]) -bash: 6b8d79e6: command not found package gpg-pubkey- is not installed

Desired outcome:
`[root@zeus:~] # rpm -q gpg-pubkey-$(echo $(gpg --throw-keyids < /etc/pki/rpm-gpg/RPM-GPG-KEY-rpmforge-dag) | cut --characters=11-18 | tr [A-Z] [a-z])
gpg-pubkey-6b8d79e6-3f49313d``

Puppet adds the backtick which make the whole check fail and results in the repeated import of the gpg key.

please sync your git version with puppet-forge's one

It's very inconvenient to install your module with git clone.

use $::lsbmajdistrelease instead of $::os_maj_version

Mirrors file is written incorrectly. Breaks on puppet 2.7.25 2.7.26. Change to $::lsbmajdistrelease and all works as expected.