GithubHelp home page GithubHelp logo

Comments (7)

NadyaNayme avatar NadyaNayme commented on June 30, 2024 1

No worries about it. System messages showing in battle tab won't change how Tidy Chat handles them as they're still sent via the System channel. "Where" a chat line comes from is different from which chat tabs it gets displayed in.

I still appreciate the report. It still helps because if I get more reports I can see if they're also using Nvidia GPU's and maybe what driver version they're running on. If I get reports from an AMD user along the same lines it might warrant some extra investigation into whats going on - but raidwides w/o chat lines shouldn't be a Tidy Chat-related thing.

from tidychat.

NadyaNayme avatar NadyaNayme commented on June 30, 2024

If you're willing to do some additional testing for me - can you try enabling/disabling specific channel filters? Like disable "Filter Loot messages", "Filter system messages", etc? Can you also provide more information on which GCDs/enemy attacks it was stuttering on?

With how Tidy Chat works and with how fast regex is it shouldn't have any impact on performance unless you're somehow getting thousands of game messages a second. So this is an extra bizarre issue.

from tidychat.

TheFwuffernaut avatar TheFwuffernaut commented on June 30, 2024

More than happy to test it later today ^^

Player GCD side its most noticeable on large aoe packs in dungeons but significantly less impactful, mob aoe side I've been experiencing the issue with all raidwides and phase 2's baited proteans in DSR/DSU (w/e you want to call it), along w/ p12s and the 6.5 trial - with much fewer issues outside of those but still noticeable drops.
I should note however that the proteans have a noticeable stutter to them even with tidychat disabled - its just much less of a stutter (quarter second compared to 2s freeze); so those may be a bad interaction rather than tidychat.

I'll get exactly what I had enabled and then do 1 by 1 testing of what should be causing things like that to happen o7

When I do said testing is there anything I should record/make sure is logged beyond just what settings I have enabled/disabled?

from tidychat.

NadyaNayme avatar NadyaNayme commented on June 30, 2024

When I do said testing is there anything I should record/make sure is logged beyond just what settings I have enabled/disabled?

It'll spam the chat but enabling Debug Mode for a period of time so that Tidy Chat logs everything it is filtering to the chat can help as it will show all messages that Tidy Chat is attempting to filter (any matched filters will pass through with a [Debug] attached). It's possible I'm matching on a chat line with a poorly optimized regex and may need to rewrite the rule.

Do you have any Custom Filters setup by the way? I don't think anyone would ever have a super complex regex filter setup but a poorly enough written one could also cause stuttering in theory.

from tidychat.

TheFwuffernaut avatar TheFwuffernaut commented on June 30, 2024

o7 just did some testing today - no chance to do DSR tests due to PF but I did test in the 6.5 trial.
It's not consistent in when it spikes at all outside of "generally on raidwides" - first and 2nd line stack were the worst later ones were fine for example, set to 0 had no lag today but was an issue previously.
Its definitely still happening but its also nowhere near as bad as it was so I think this isn't tidychat so much as 6.5 fucking something up/a combination of small spikes causing a singular big one from multiple plugins experiencing the same issue (and/or my hardware being problematic in general - nvidia card on new patch and all :))) ).
I attached screenshots of all my usual settings - 0 custom filters and there WAS a noticeable difference between system filter on/off but that was it as far as I could tell from testing.
Also again as I said it wasn't consistent at all and much less bad compared to before so I may just be wrong here about all this.

image
image
image
image
image

from tidychat.

NadyaNayme avatar NadyaNayme commented on June 30, 2024

During those raidwides does the boss even have any dialogue that gets sent to the chat box? If there's nothing being sent to chat during those times it can't be Tidy Chat since Tidy Chat only performs logic when a chat message is received.

I can't imagine what it would be - especially if it's a 1s~ hang. Regex won't really run into performance issues at the scale Tidy Chat works with. Even a very poorly written regex can run 10,000 - 100,000 times/second with no issue on text that is <1000 characters. The patch not getting along with your GPU/drivers is honestly a more plausible explanation.

I have some pretty questionable regex patterns in Tidy Chat but even the worst of them can run 1,000,000's of times per second without issue on the average line of text of a chat message.

from tidychat.

TheFwuffernaut avatar TheFwuffernaut commented on June 30, 2024

It's probably not tidychat then and probably something 6.5/hardware side that's causing the issue - apologies for the thread regarding all this then ^^''

The boss doesn't have anything for the 2nd/3rd line stacks in chat - there is a popup saying "X drinks deep of Y's soul..." as its casting thoug (and it does line up with Thordan's "WHAT" in DSR for proteans although I don't think that gets sent to chat? Just a voiceline) so afaik its just in the battle log which I have system messages set to come out to as well hence me thinking that something was going wrong there.

from tidychat.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.