GithubHelp home page GithubHelp logo

Comments (7)

nathanhoad avatar nathanhoad commented on June 20, 2024

When I use your example dialogue it appears to work for me (except I renamed name to player_name because name is already a property of Node):

image

Can you verify your Dialogue Manager version is 2.38.0?

from godot_dialogue_manager.

ohin avatar ohin commented on June 20, 2024

That's weird :) Because here I am attaching minimal reproduction project, where I isolated the issue.
dialogue_manager_issue_553.zip

from godot_dialogue_manager.

nathanhoad avatar nathanhoad commented on June 20, 2024

Yeah you're missing the line that was added to fix this issue a little while ago: https://github.com/nathanhoad/godot_dialogue_manager/blob/main/addons/dialogue_manager/dialogue_manager.gd#L145

That does present a different problem though - somehow the swapping of files on update isn't working properly any more.

from godot_dialogue_manager.

ohin avatar ohin commented on June 20, 2024

Actually, to the MRP the plugin was obtained through asset store. So there was no update path. Therefore I am guessing the fix is missing in the released version?

from godot_dialogue_manager.

nathanhoad avatar nathanhoad commented on June 20, 2024

Oh wow I'm an idiot - turns out the fix hasn't actually been released yet. Here I was about to tear the auto-update apart trying to find out why it wasn't working.

I'll do a release now. Thanks for pointing me to the actual problem 👍

from godot_dialogue_manager.

nathanhoad avatar nathanhoad commented on June 20, 2024

I just released v2.39.0 and verified that upgrading fixes the issue in that MRP project.

from godot_dialogue_manager.

ohin avatar ohin commented on June 20, 2024

Great, I am glad I could help. Thank you for the great plugin!

from godot_dialogue_manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.