nats-io / nats.js Goto Github PK

Observed behavior

Readme states:

The core module also offers a for W3C Websocket transport (aka browser, Deno, and Node v22) via the exported wsconnect function.

However, @nats-io/nats-core does not export wsconnect (or any other function that is relevant to connections for that matter.)

@nats-io/nats-core comes from npm. I discovered it while trying to walk around #48 as it's impossible to download any JSR modules for Deno (including transport-deno one.) The source code seems to export wsconnect but in the final build it's not available.

Expected behavior

wsconnect is exported

Server and client version

@nats-io/[email protected] from npm

Host environment

No response

Steps to reproduce

No response

Observed behavior

For nats-core, on jsr latest version is 3.0.0-25 whereas npm is at 3.0.0-17. Same for kv (-3 vs -7).

Expected behavior

jsr and npm versions are even

Server and client version

(Should it really be a required field?)

Host environment

No response

Steps to reproduce

No response

Observed behavior

1. install application using this command because i needed websockets: npx jsr add @nats-io/nats-core
2. module import wasn't resolving: import * as Nats from "@nats-io/nats-core";
3. changed: "moduleResolution": "node" to "moduleResolution": "bundler",
4. everything seemed to resolved.
5. compiled application and received this error:
   Error: node_modules/@nats-io/nats-core/_dist/src/headers.d.ts:25:21 - error TS2371: A parameter initializer is only allowed in a function or constructor implementation.

25 delete(k: string, match = Match.Exact): void;

Expected behavior

N/A

Server and client version

latest

Host environment

linux

Steps to reproduce

N/A

Observed behavior

Downloading module via JSR does not work (this command was taken from Readme file)

$ deno add @nats-io/obj
error: jsr:@nats-io/obj was not found.

Also, visiting jsr.io page shows:

This package has not published a stable release yet.

Some misconfiguration maybe?

Expected behavior

It works.

Server and client version

$ deno -v
deno 1.45.5

Host environment

No response

Steps to reproduce

No response

Observed behavior

esbuild dev bundle

[DEBUG] Indirect calls to "require" will not be bundled [indirect-require]

../../node_modules/tweetnacl/nacl-fast.js:2378:20:
      2378 │   } else if (typeof require !== 'undefined') {
           ╵                     ~~~~~~~

Expected behavior

nacl-fast.js as ESM module

Server and client version

"@nats-io/nats-core": "^3.0.0-25"

"esbuild": "^0.23.1"

Host environment

No response

Steps to reproduce

No response

Proposed change

Use strict MAJOR.MINOR.PATCH semantic versioning. Currently a -N suffix is added to a version.

Use case

I'm not sure what's use of the suffix for this library but it causes problems in Deno when downloading most recent version of the library:

> import * as mod from "jsr:@nats-io/nats-transport-deno"
Uncaught TypeError:
    Could not find version of '@nats-io/nats-transport-deno' that matches specified version constraint '*'

I think it would be beneficial for everyone to adhere to commonly used naming conventions to ensure compatibility across diverse JS ecosystem.

Contribution

No response

Proposed change

Export StorageType found in @nats-io/jetstream in @nats-io/obj

Use case

Creating a bucket with custom storage uses (objm.create("myobj", { storage: StorageType.File })) enum from jetstream requiring user to individually add both obj and jetstream packages to pkg manager.

Contribution

With pleasure. Is this a change core contributors would be interested in reviwing?