Comments (3)
Hey @GriffinMB, I've recently included Sobelow as one of curated checks in the mix check
task in order to make it more visible in the Elixir ecosystem (it took myself long enough to discover it...).
What's important for this issue is that not long after I've discovered that it doesn't work at all (by raising FunctionClauseError
on Utils.binarize_app_name
) when executed from the root of an umbrella project. As I understand, this issue (as well as several linked ones) is here in hope to address that limitation. So for those having this issue I'd like to report that Sobelow works perfectly fine in umbrella projects right out of the box when used with mix check
task provided by ex_check package. Hope that helps those wanting to use Sobelow in larger projects - which usually need security checking more than the others - until the issue is addressed in the library.
Btw it works because mix check
has its own layer for recursion over umbrella child apps and I've updated Sobelow's stock configuration to mark it as a recursive tool (in https://github.com/karolsluszniak/ex_check/blob/master/lib/ex_check/config/default.ex#L10) even though mix sobelow
doesn't have the @recursive true
flag (I'm not sure why - I do believe that Sobelow needs to recurse over umbrella apps one way or another e.g. to properly check multiple web applications in single umbrella).
from sobelow.
This has been added and will be available in the next release. Thanks!
from sobelow.
If you want to make a PR adding @recursive true
, that sounds like a fine option to me. Otherwise, I will make the update ahead of the next release.
raising FunctionClauseError on Utils.binarize_app_name
That error is addressed in a previous commit, so will no longer be so ugly in the future :)
from sobelow.
Related Issues (20)
- Add new output format for sonarqube HOT 1
- multiple routers (not an umbrella :) ) HOT 1
- Add support for --version opt
- Plans for ongoing maintenance? HOT 4
- Traversal.FileModule Issue. HOT 1
- Macro.to_string/2 deprecation warning HOT 3
- Please match hex version code with github? HOT 1
- Support detecting for Wildcard check_origin Vulnerability
- Create robust testing suite against other popular Elixir repos
- Suggestion for installation instructions HOT 1
- Add production runtime config to the missing HTTPS check HOT 3
- LiveView Support
- castore vsn requirement HOT 3
- CAStore error when running as standalone script HOT 7
- DevEx: consider defaulting to [FILE_PATH]:[LINE_NUMBER] format for default vulnerability output HOT 2
- Too much info in --details / -d output HOT 2
- Creating Performance Testing Suite
- Misc.BinToTerm with [:safe] option HOT 2
- (Protocol.UndefinedError) error HOT 8
- Source code with range traversal crashes sobelow HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sobelow.