GithubHelp home page GithubHelp logo

Comments (3)

karolsluszniak avatar karolsluszniak commented on May 9, 2024 1

Hey @GriffinMB, I've recently included Sobelow as one of curated checks in the mix check task in order to make it more visible in the Elixir ecosystem (it took myself long enough to discover it...).

What's important for this issue is that not long after I've discovered that it doesn't work at all (by raising FunctionClauseError on Utils.binarize_app_name) when executed from the root of an umbrella project. As I understand, this issue (as well as several linked ones) is here in hope to address that limitation. So for those having this issue I'd like to report that Sobelow works perfectly fine in umbrella projects right out of the box when used with mix check task provided by ex_check package. Hope that helps those wanting to use Sobelow in larger projects - which usually need security checking more than the others - until the issue is addressed in the library.

Btw it works because mix check has its own layer for recursion over umbrella child apps and I've updated Sobelow's stock configuration to mark it as a recursive tool (in https://github.com/karolsluszniak/ex_check/blob/master/lib/ex_check/config/default.ex#L10) even though mix sobelow doesn't have the @recursive true flag (I'm not sure why - I do believe that Sobelow needs to recurse over umbrella apps one way or another e.g. to properly check multiple web applications in single umbrella).

from sobelow.

GriffinMB avatar GriffinMB commented on May 9, 2024 1

This has been added and will be available in the next release. Thanks!

from sobelow.

GriffinMB avatar GriffinMB commented on May 9, 2024

If you want to make a PR adding @recursive true, that sounds like a fine option to me. Otherwise, I will make the update ahead of the next release.

raising FunctionClauseError on Utils.binarize_app_name

That error is addressed in a previous commit, so will no longer be so ugly in the future :)

from sobelow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.