ncharlton02 / chroniker Goto Github PK

The current code for converting milliseconds to a string uses a while loop to calculate the minutes. However it uses while loops whereas it could be much more efficient/shorter if we used arithmetic like the seconds and milliseconds.

Current Code:

let millis: f64 = (self.elapsed_millis() % 1000) as f64 / 1000.0;
let mut seconds = self.elapsed_millis() / 1000;
let mut minutes = seconds / 60;
      
while seconds >= 60{
     seconds -= 60;
     minutes += 1;
}

Currently when converting 4 years to days it doesn't account for leap years.