ned-code / moodle-block_marking_manager

Name: NED - Marking Manager
Type: Block
Moodle version required: 3.0 +
For Documentation, go to http://ned.ca/plugins/

moodle-block_marking_manager's Issues

Teachers are included in "Not Submitted" list

We are encountering an issue where when we open Marking Manager and view those who have not submitted, even teachers are included in the list.

When viewing the "Student List" (via the link on the Marking Manager block), teachers are not included.

Not sure if it's of relevance, but we have edited the default moodle roles (a different role was renamed to students, but the default teachers role are unchanged)

Problem with grading page. Thread continue from #24

I had installed latest code as per your suggestion. I am getting "186 Required Grading" on course page.
But when i clicked on that link it give me "No Selected Assignment".

It was working in older version. But not wor

king in latest version.

Issues with display of 'marking status' tables

Hi NED guys,

First off, thanks kindly for the awesome plugin!

We've discovered a problem with the 'marking status' tables that get put together to show correct / incorrect answers for a quiz. Only correct answers get added to the table, questions manually graded as incorrect (and description type questions) don't get included in the table as I presume they should.

As such, the ticks for correct answers do not line up with the relevant questions on the 'marking status' page.

If you look at the attached screenshot, the top half shows how a quiz was manually graded. You'll see there's 4 description type questions throughout the quiz. The first 5 gradable questions were marked '0', the last 5 marked '1'.

Now, look at the bottom half of the screenshot, which shows the table Marking Manager created to depict these scores. You'll notice only the correct answers are displayed, and do not correspond with the relevant questions. Below, in the orange outline, is a table I quickly mocked up in Photoshop which shows how I would expect the table to be displayed.

Moodle version - 3.3.2+ (Build: 20170922)
Theme - Boost
NED Marking manager version - 3.3.1 (2017083001)

Hope that's of use, let me know if you've got any questions about this.

Thanks,

Tim.

Not yet graded quiz shows in graded group

In the plugin, not-yet-graded quiz is in the graded group instead of require grading. However, this quiz has some questions requires manual grading and allows 2 attempts. Also, I need to check "show all participants" box to show this attempt in the view.

Moodle 3.0: PHP catchable fatal error when saving grade

Thank you for the great plug-in. We just updated to Moodle 3.0 and now the teachers get an PHP catchable fatal error when they try to mark an assignment (right after they click 'save'). Any idea how this can solved?

Thanks a lot in advance!

Frank

Delete Assignment

Feature request:

If the Superuser is logged in, at present there is no easy way to delete an assignment attempt. This feature would be really helpful to delete sticky records due to files being uploaded via the wrong link.

An Admin-only delete button would be really useful.

group issues

I know this is not ready yet for Moodle 3.0. Just listing these here to follow it up.

1. the block showing total number of quiz "Requires Grading" instead of only from the teacher's group (access all groups permission is set to prevent)
   https://goo.gl/photos/hxV1x4oSLVHSzhPL9
2. In the list of Marking status "Requires Grading" the the same thing happens. The number on the left reflects the total number of ungraded assignments from all participants irrespective of any entry for the group the teacher is in. It should not even list that quiz in the first place.
   https://goo.gl/photos/AAa5chVq5pQnsfow8

Page load problem with FN Marketing

Hello Fernado,

Hope you are doing good.
I am using block "FN Marking". It is good plugin which meet our requirement.
We are using moodle 3.1 and FN Markeing 2.9 version. We are facing page load problem with this plugin.
I am attaching two screen shot. One is for course page and another one is for FN Marketing block.
FN Marketing take almost 23 Second each time to load page.

We have already Opcache enabled on server. still it take too much time. Can you please help me out on this?

Regards,
Harshil

Auto Update

Hi

We update moodle every week and most of the plugins are detected and updated but Marking Manager is not, it says Missing from Disk and then you have to find it.

Please, can you make it so that it automatically updated when you update moodle as we use a lot of your products including homework, mentor, progress and marking? It would be so much appreciated. Thank you.

Slow initiation on very large course

We run a 3 week 800 users course with 10 quizzes.
It takes a full minute for the course frontpage to load when we add the block/marking_manager to the course.

Maybe you can move some of the initial calculations into a clickable "more info" action, so it could be calculated on demand and not each time the front page is displayed.

(sadly, for now, we removed the block from the course)

We LOVE your block and looking forward to be using it after this issue is solved.

Last Access for Students who have never logged in

Students who have never logged in are reported as Last Access Thursday, 1 January 1970.

CSS Conflict in Moodle 2.7.4 with Lesson Menu

Hi Fernando,

I'm having issues with the previous reported CSS Conflict with the .menuwrapper class. It seems to still be occurring with the plugin in version 2015111400 for Moodle 2.7.4. When I delete the block the issue is resolved.

Best Regards,
Sam

PHP Notice: Undefined index: numsections in /data/www/moodle/moodle/blocks/fn_marking/fn_gradebook.php on line 363

Hi Fernando,
We have another that has presented itself.
Not sure why a lot of the notifications for NED marking aren't registering...
I am debugging locally but hoped you may have some insight.

Moodle - Moodle 3.3.1+ (Build: 20170901)
Marking Manager - block_fn_marking - 3.3.1 2017083001

[Fri Sep 29 00:26:33.687442 2017] [php7:notice] [pid 19916:tid 140215607830272] [client 02.166.250:53272] PHP Notice: Undefined index: numsections in /data/www/moodle/moodle/blocks/fn_marking/fn_gradebook.php on line 363, referer: http://moodle.ca/blocks/fn_marking/fn_gradebook.php

[Fri Sep 29 00:28:00.243111 2017] [php7:notice] [pid 30748:tid 140215691757312] [client 99.19.19:49367] PHP Notice: Undefined index: numsections in /data/www/moodle/moodle/blocks/fn_marking/fn_gradebook.php on line 363, referer: http://moodle.ca/grade/report/grader/index.php?id=851

ALERT INACCURATE: 10 Students have not submitted any activities for 7 days

This Alert is Inaccurate: "10 Students have not submitted any activities for 7 days"

Marking Manager shows the ALERT as follows:

List of 10 Students who are reported not to have any Activities submitted during the last 7 days

Example for Title of Assignment with submissions during the last 7 days

List of submissions during the last 7 days of the Assignment used as an Example

Please advise urgently - Students are confused

Requires grades throws error

Requires grading does not seem to be working. After clicking, the 'Activity Type' and 'Participant' drop downs are not working, ditto for 'Less' and 'More'. When clicking 'Requires Grading' the following error is thrown and displayed via Moodle debugging:

Fatal error: Call to undefined method assign::get_grading_status() in /var/www/moodle/blocks/fn_marking/assign_edit_grade_form.php on line 357

Feature request: add support for lessons

Dear supporters,

I really like marking manager, as do the teachers. Currently, the main drawback is that we cannot show lessons with to be graded open questions, while we use them extensively. Could support for them be added? Is this hard? Otherwise, with some pointers, I might be able to do it myself.

Thanks in advance,

       Frank

utf8mb4 encoding causes install issues

Moodle will begin to recommend utf8mb4 in upcoming versions. https://tracker.moodle.org/browse/MDL-54901

I've recently attempted to install fn_marking_manager on a new 3.3 running with utf8mb4 collation. It will not install because of the ix_cor_mod_us unique key being too many bytes. Keys have a maximum of 191 characters, or 764 bytes.

[postgres only] exception on each pages including the block

First I just want to say: great job! It is always nice to see a new require_grading plugin and this one even implement fast grading!

Default exception handler: Error reading from database Debug: ERROR: invalid input syntax for type numeric: ""\nLINE 5: ... AND (qa.sumgrades IS NULL OR qa.sumgrades = '')\n ^\nSELECT COUNT(DISTINCT qa.userid)\n FROM mdl_quiz_attempts qa\n WHERE qa.quiz = $1\n AND qa.state = 'finished'\n AND (qa.sumgrades IS NULL OR qa.sumgrades = '')\n[array (\n 0 => '112033',\n)]\nError code: dmlreadexception\n* line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown\n* line 244 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()\n* line 764 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()\n* line 1476 of /lib/dml/moodle_database.php: call to pgsql_native_moodle_database->get_records_sql()\n* line 1549 of /lib/dml/moodle_database.php: call to moodle_database->get_record_sql()\n* line 1759 of /lib/dml/moodle_database.php: call to moodle_database->get_field_sql()\n* line 203 of /blocks/fn_marking/lib.php: call to moodle_database->count_records_sql()\n* line 717 of /blocks/fn_marking/lib.php: call to quiz_count_ungraded()\n* line 3091 of /blocks/fn_marking/lib.php: call to count_unmarked_activities()\n* line 308 of /blocks/fn_marking/block_fn_marking.php: call to fn_build_ungraded_tree()\n* line 120 of /blocks/fn_marking/block_fn_marking.php: call to block_fn_marking->get_frontpage_content()\n* line 785 of /blocks/moodleblock.class.php: call to block_fn_marking->get_content()\n* line 236 of /blocks/moodleblock.class.php: call to block_list->formatted_contents()\n* line 1002 of /lib/blocklib.php: call to block_base->get_content_for_output()\n* line 1054 of /lib/blocklib.php: call to block_manager->create_block_contents()\n* line 369 of /lib/outputrenderers.php: call to block_manager->ensure_content_created()\n* line 26 of /theme/gourmet/layout/frontpage.php: call to core_renderer->standard_head_html()\n* line 885 of /lib/outputrenderers.php: call to include()\n* line 815 of /lib/outputrenderers.php: call to core_renderer->render_page_layout()\n* line 101 of /index.php: call to core_renderer->header()\n, referer: https://test.vlacs.org/admin/search.php?query=debug

basically it's the quiz sql: qa.sumgrades = ''
It is not possible to check a numeric field against '' in postgres

Cron job taking a long time

What does the cron task for NED do? It takes about an hour and a half to run each time.

Maximum Grade not Showing

For assignments that use the Grade Type “Point”, the maximum grade does not show in the Marking Manager. You are given the box in which to type the grade, but not information for what the grade is out of. This means that you have to open the assignment to see the maximum grade before you can assign a grade in the Marking Manager, which defeats the point of using it. I can’t find any place where this might be configurable to show/hide.

No participants found for this course

Hello when clicking Student List on the FN Marking Manager block the following error is shown No participants found for this course. There are students enrolled on the course and the progress report displays correctly.

Thanks

Not compatible with groups

Thanks for the great plugin! I bump into one small problem. I have three different assignments which need to be graded in my course. However, for only one I can actually see the student submission. The only unique property of this assignment seems that it is an individual assignment, while the others are group assignments. Can this be the cause; can FN Marking Manager handle group assignments? If this is not the cause, anyone any idea what it can be?

Thanks in advance!

Frank

Announcement regarding future updates

Dear NED Plugin users:

We have been maintaining these plugins for many years and raising funds to keep this work going has been an ongoing challenge, especially in the last couple years. To keep these plugins alive, we must shift to a paid membership model. This decision was not taken lightly, since we value and appreciate the spirit of sharing that is demonstrated daily by the Moodle community at large. But we also don’t want to abandon our plugins and the schools that rely on them. We hope that this move will allow us to improve the quality of our plugins and keep pace with the timeline of the Moodle releases. We are still figuring out the details but it’s likely that we will offer a tiered membership system (ex. different prices for individuals vs schools) as well as options for non-profits. We look forward to updating our current lineup of plugins and to creating new plugins to meet the needs of learners and instructors alike.

If you or your school is interested in becoming a member, please complete this form https://goo.gl/forms/4Cfk8eu5YAxc63Gc2

Assignment stays shows "Requires Grading" still after being marked

Using Moodle 2.9 and fn_marking block

The assignment has already been marked via "Requires Grading". The odd thing is the assignment still stays there even after purging the cache.

Sort Simple Gradebook by Last Name

Right now in the simple gradebook students are listed by first name, initial. (e.g. Smith, J.) and are sorted by Moodle user ID. I was able to get around this by changing line 69 in simple_gradebook.php from:
$simplegradebook[$key]['name'] = $value->firstname.' '.substr($value->lastname,0,1).'.';
to:
$simplegradebook[$key]['name'] = $value->lastname.', '.$value->firstname;

Might be useful to build this option into the block configuration.

Refresh Button not Displaying in Some Courses on 3.5

We observed some instances of courses, the refresh button is not available.

When we looked at it we noticed that by changing the logic in block_fn_marking.php on line 373 from:

if ($cachedatalast === false) { $humantime = get_string('lastrefreshrequired', 'block_fn_marking'); $showrefreshbutton = true; $this->content->items = array(); $this->content->icons = array(); **} else if ($cachedatalast > 0) {** $humantime = get_string('lastrefreshtime', 'block_fn_marking', block_fn_marking_human_timing($cachedatalast)); $showrefreshbutton = true; } else { $humantime = get_string('lastrefreshupdating', 'block_fn_marking'); $showrefreshbutton = false; }

to:

if ($cachedatalast === false) { $humantime = get_string('lastrefreshrequired', 'block_fn_marking'); $showrefreshbutton = true; $this->content->items = array(); $this->content->icons = array(); **} else if ($cachedatalast >= 0) {** $humantime = get_string('lastrefreshtime', 'block_fn_marking', block_fn_marking_human_timing($cachedatalast)); $showrefreshbutton = true; } else { $humantime = get_string('lastrefreshupdating', 'block_fn_marking'); $showrefreshbutton = false; }

It appears that the system is checking a global value for when the last time the user commited a refresh somewhere else in the site, this is causing the fresh timer not to pass with a positive value.

pix_url() is deprecated: moodle 3.3 compatibility issue

As a part of Moodle 3.3 compatibility, fn_marking_manager needs to address the following change.

pix_url() is deprecated

NED says I have unmarked Forum posts, but I don't

Over time, most - if not all - of my Forums are listed by NED as having 1 unmarked Forum post. But they are all marked. This eventually affects all the forums so that after a few months, all of the forums supposedly have one unmarked post. And whenever somebody actually does post to the forum, it still says 1 unmarked, therefore once or twice per week I need to go through all the forums to check what the situation actually is.

Using NED Version: 2016092700 on Moodle 3.1.1+ (Build: 20160901)

Cron is giving me Trying to get property of non-object in /var/www/moodle/blocks/fn_marking/lib.php on line 688

Error happens over and over on this line:

if (!isset($modgradesarray[$mod->modname])) {

Seperate group select resets on marking

Hi,

In the Marking Manager, I select a group, after grading and saving, the 2nd time I click 'save', the group selection goes back to 'All Participants'

I'm using
Moodle 3.0.5+ (Build: 20160721)
NED Marking manager Version: 2016090600

Thanks
Al

Moodle 2.5, problem with simple gradebook

I have a fresh copy of moodle 2.5, newest version of FN Marking Manager and clean theme installed. When I click the link to gradebook it takes me to a blank page. I tried to reinstall plugin, it didn't help.

"Not Submitted" issue

Fernando,

We are currently running Moodle 3.3.4 (Build: 20180115) and NED Marking Manager version 3.3.2 (Build: 2017120900).

The issue that we are seeing is the fact that quizzes that need manual grading are not showing up under "Requires grading" but in the "Not submitted" area, therefore the teachers are not grading them...

According to the documentation, the "Not submitted" area should display only Assignments and/or forums that are not submitted, why are these quizzes showing up there instead of under "Requires grading?

The image below shows what the MM displays in the front of the course:

The image below displays what is shown once the "Not submitted" link above is cliked:

Please let me know how we can correct this issue. Thank you very much!
Sam Villamizar

Layout issue with online text

the "fn_plugin_wrapper_outer" is floated so it falls beneath "fitem_id_onlinetext". "fitemtitle" also is floated so it pushes the editor icons more to the right as well

conflict with CSS selector .menuwrapper

FN Marking manager and Lesson (Left menu) conflict because both use CSS selector .menuwrapper
https://tracker.moodle.org/browse/CONTRIB-5922

invalidrecord when clicking on requires grading

In two courses a teacher has, when she clicks on the 'reqires grading' link, she gets the following error:

[06-Oct-2015 11:45:54 America/Denver] Default exception handler: Can not find data record in database table course. Debug: SELECT * FROM {course} WHERE id IS NULL
[array (
)]
Error code: invalidrecord

• line 1451 of \lib\dml\moodle_database.php: dml_missing_record_exception thrown
• line 1427 of \lib\dml\moodle_database.php: call to moodle_database->get_record_select()
• line 588 of \lib\datalib.php: call to moodle_database->get_record()
• line 487 of \lib\grouplib.php: call to get_course()
• line 781 of \lib\grouplib.php: call to groups_get_activity_groupmode()
• line 322 of \blocks\fn_marking\fn_gradebook.php: call to groups_get_activity_group()

FN block version: 2015100100
Moodle Version: 2.8.6+ (20150618)

Block shows courses with no ungraded activities

We have a lot of courses, managed by one and the same teacher. The marking manager helps us out greatly here. However, it does not hide courses where there are no ungraded activities, which means we reach the maximum of 10 courses really soon, and can't see the actually relevant courses. Any pointers on what might be going wrong here?

Thanks in advance,

        Frank

Errors found using Moodle 3

Hi,

I am using Moodle 3.0.2. I received a few errors as follow:

1- Notice: Undefined index: numsections in Moodle folder\blocks\ned_marking\fn_gradebook.php on line 283.

2- Notice: Undefined index: news in Moodle folder \blocks\ned_marking\forum.submissions.fn.php on line 146.

3- fn_gradebook.php shows this message: "Coding error detected, it must be fixed by a programmer: PHP catchable fatal error" when I tried to save the new grade for student.

Thank you

Progress Report page displays all groups despite "separate group" being set to Yes

The course's "Separate groups" setting has been set to yes, so that a teacher cannot see another teacher's students. When viewing Gradebook or Student List, it is working as intended and the teacher can only see his/her own students (who are in the same group as the teacher)

However, when viewing the Progress Report page, the teacher is able to view all students including those from other groups.

Work to be graded not showing on teacher's dashboard or home page

Work to be graded shows on administrator's home page, but will not show on teacher's home page.
Moodle 3.1, Marking manager 3.2.1. Have added block to teacher's page, the block is there it just isn't showing any thing to be graded that is attached to them (via a group). Have run cron.

Courses with 0 ungraded items in front page mode

I'm getting a lot of courses that don't have ungraded assignments show up in the list. Is this the intended result?

Error when trying to access Blogs to rate within the block

Dear Fernando,

Thank you very much for this useful block. We have been using it for the last month and all instructors are liking it very much!
The only issue that we have found with the block is that when trying to rate blogs via the block, we get an error (see attached image). We are able to access all other assignments (quizzes, drop boxes) without any issues.

We are using Moodle 2.9.2+ (Build 20150918)
With a Postgre database v. 9.3.10
FN Marking block: 2015100100

When I enable debugging mode, this is what it displays:

Error reading from database
More information about this error

Debug info: ERROR: column "u.id" must appear in the GROUP BY clause or be used in an aggregate function
LINE 1: SELECT u.id as id, u.id AS userid, SUM(r.rating) AS rawgrade
^
SELECT u.id as id, u.id AS userid, SUM(r.rating) AS rawgrade
FROM mdl_user u
LEFT JOIN mdl_forum_posts i
ON u.id=i.userid
LEFT JOIN mdl_rating r
ON r.itemid=i.id
WHERE r.contextid = $1
AND r.component = $2
AND r.ratingarea = $3
AND i.userid = $4
[array (
0 => 299771,
1 => 'mod_forum',
2 => 'post',
3 => '1796',
)]
Error code: dmlreadexception
Stack trace:
line 443 of /lib/dml/moodle_database.php: dml_read_exception thrown
line 244 of /lib/dml/pgsql_native_moodle_database.php: call to moodle_database->query_end()
line 764 of /lib/dml/pgsql_native_moodle_database.php: call to pgsql_native_moodle_database->query_end()
line 1478 of /lib/dml/moodle_database.php: call to pgsql_native_moodle_database->get_records_sql()
line 190 of /blocks/fn_marking/forum.submissions.fn.php: call to moodle_database->get_record_sql()
line 650 of /blocks/fn_marking/fn_gradebook.php: call to include()

Please let me know how I can resolve this issue. So far what instructors are doing is going to the block to see what blogs need grading, they write them down and then go to the course's main page to grade them.

Have a blessed day,
Sam Villamizar

Work not showing

After updating to the latest NED Marking Manager, no work is showing that needs marking. I am running Moodle 3.3.1+ (20170824). I'm using Mac OS 10.12.5. Chrome Browser.