neo-ngd / cneo-contract Goto Github PK

The error is in line: https://github.com/neo-ngd/CNEO-Contract/blob/master/NeoContract/CNEO.cs#L267

NEP-10 Specification: https://github.com/neo-project/proposals/blob/master/nep-10.mediawiki
NEP-10 Specification sample code: neo-project/proposals#40 (comment)

Was this SC code reviewed? Was it tested?

Could you provide avm file so we can test in out privatenet?
Thanks.

这里应该检查所有的outputs，只有都满足条件才将 ifClaimGas 设置为 false；否则一个output满足就可以绕过这个检查，并没修复那个漏洞。
也许可以改为：

bool ifClaimGas = false;
foreach (var output in outputs)
{
    if (output.ScriptHash.AsBigInteger() != currentHash.AsBigInteger() || output.AssetId.AsBigInteger() != AssetId.AsBigInteger())
        ifClaimGas = true;

Originally posted by @chenzhitong in #6 (comment)