neolynx / cirrina Goto Github PK

Why is there no:

from cirrina import Client

Do we need one?

When uploading files, it's possible that "recived_filename" is not yet defined when it's used. See:

E.g. error log:

local variable 'received_filename' referenced before assignment
                                               Traceback (most recent call last):
                                                 File "/opt/roche/home/cirrina/cirrina/server.py", line 356, in _wrap
                                                   ret = (await func(request))
                                                 File "/opt/roche/home/cirrina/cirrina/server.py", line 458, in upload_handler
                                                   filename = received_filename.replace("\"", "")
                                               UnboundLocalError: local variable 'received_filename' referenced before assignment

Does the javascript websocket client implementation really belong to the package content?
It's just another implementation of a client which is able to talk to a cirrina server.
The examples/documentation might be a better place.

I want to be able to easy send messages to all websocket clients opened by a specific session/user.

Current implementation is not compatible with aiohttp2.2

Publish package to PyPI.
@neolynx ?

Create debian/ files

When shutting down cirrina while using Python 3.9, I get this error:

^CTraceback (most recent call last):
...
  File "/usr/lib/python3/dist-packages/cirrina/server.py", line 183, in run
    for task in asyncio.Task.all_tasks():
AttributeError: type object '_asyncio.Task' has no attribute 'all_tasks'

The problem is that asyncio.Task.all_tasks was deprecated in py3.7 and removed in py3.9:
https://docs.python.org/3.8/library/asyncio-task.html#asyncio.Task.all_tasks

Write README containing small documentation ...

The session wrapper swallows any exception, therefore preventing aiohttp idiomatic use of HTTPExceptions for control flow.

For example, this handler wouldn't work (see https://docs.aiohttp.org/en/stable/web_quickstart.html#exceptions):

async def handler(request):
    raise aiohttp.web.HTTPFound('/redirect')

because the exception would be caught in the above "session wrapper" except clauses and never re-raised.