GithubHelp home page GithubHelp logo

ca-hospice-hope's People

Contributors

hedgehogholly avatar j-gynn avatar katjam avatar nikomus avatar robpre avatar rosejbon avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

ca-hospice-hope's Issues

Bugs from Testing

Description

Fix the bugs!

Bugs

  • The keys for the story teaser links are doubled up.
    image

  • The copyright URL looks like Hospice Hope, but doesn't go to the right destination

  • Better markup/ styles for phone cta (raise issue in contemplating action core) - not here
    Screenshot_20190815_141117
    Screenshot_20190815_141136

Add Hazel and Collin's Story

Description

Add Hazel's Story to the app.

The copy for the story is here: https://docs.google.com/document/d/1KAiAL2HYT1gTzluG8kVRIEM-gOPfZ9_WRCL6FNQ9h0Q/edit?usp=sharing

Folder for illustrations: https://drive.google.com/drive/folders/1jKv0jG0sZR8cNcLQXi6VPWfpnA414Asx?usp=sharing

Plan

  • Add copy Hazel's Story
  • Add alt text

Acceptance Criteria

Small Issues

These are some small-fry issues I noticed when testing other issues.

  • There is an unnecessary space after Part 1 of 4 of Hazel's story.
    image
  • Bite-size information is center-aligned, which can make it hard to read.
    image
  • The mobile link in the small-viewport navbar has a doubled tel: prefix (tel:tel:01530222079), making it unusable on desktop and having it yield an incorrect number on mobile.
    image
  • The header stops being a link to the homepage on the homepage itself. This goes against the grain, as most websites preserve the link to provide a consistent "go to home" button and to allow for the homepage URL to be copied easily. (won't fix - but @Nikomus @roseb04 we should check if this is normal/ expected)
    image
  • The copyright URL ends up on its own line, in whatever size viewport.
    image
  • The website title is briefly "Hospice Hope" instead of "Hospice Hope Stories" before the page finishes loading.
  • In small viewports, with the navbar at the bottom, there is empty space to scroll to even when the page is not sufficiently large.
    image
  • Our "Call" link for mobile devices is also shown on desktop when the viewport is small enough. On my work laptop (Firefox 68.0.2, Ubuntu 19.04) this link does not go anywhere, as no applications are installed that support the protocol implied by tel:. We should probably look into general desktop support for this prefix.
    image
  • One of the favicon <link> elements has a typo'd rel attribute.
    <link rel="favicon" type="image/ico" href="favicon.ico">
    should be
    <link rel="icon" type="image/ico" href="favicon.ico">

Platform

Firefox 68.0.2, Ubuntu 19.04

Update icons

User Story

We need to add the Hospice Hope icons, whatever they are

Acceptance

  • hospice hope icons added

Call link shown on desktop

Description

  • Our "Call" link for mobile devices is also shown on desktop when the viewport is small enough. On my work laptop (Firefox 68.0.2, Ubuntu 19.04) this link does not go anywhere, as no applications are installed that support the protocol implied by tel:. We should probably look into general desktop support for this prefix.

image

Cookie Banner

Description

We need to give people the option to opt into having Google Analytics track them on the site

Plan

  • Think about how we do this
  • What copy are we using?
  • Accessibility thought!

Acceptance Criteria

  • People opt-in not opt-out of cookies
  • The cookie notice is clear and easy to find
  • Opt in and opt out are given equal weight
  • People can change their minds

Include some more headings in the outline?

Description

Some sections, while made distinct with visual styling and HTML5 <section> tags, are left without headings. This leaves them invisible and unlabelled in the document outline. For each section, it should be considered as to whether they would be deserving of a place in the outline. e.g.
* The information given after a story:
image
* The dates given within "When do sessions take place?"

Plan

  • Step one to achieve this.
  • Step two to achieve this.

Add GitHub issue templates

Description

We should add the GitHub issue templates we use elsewhere to make the repo easier to work with

Plan

  • Add the .github template folder

Format images (stories & homepage)

Resize and compress story images.

Plan

  • Choose dimensions and format, from existing images
  • Resize and compress, testing for visual quality
  • Include the images in brand repo

Add Cookie Banner Keys

Description

The cookie banner in the core repo introduces three new keys, we should reproduce them here.

Plan

  • Add the three keys to BrandCopy.elm, with the same string values

Copyright url on its own line

Description

  • The copyright URL ends up on its own line, in whatever size viewport.

image

  • change the link text to organisation name

Update Meta Image

Description

When we have hosting arranged, the meta image url should be changed to the live banner image. We should also update the description to the final copy: "People who come to us have illnesses that are seriously affecting their lives. Read about how visiting us helped them. Could we help you too?"

Plan

  • update the image
  • update the description

Add/remove quotes for Shane and Gary's Stories & make possible for every card to have a message or not

Description

Need to add the messages that accompany Shane and Gary's stories.

The copy for Shane's story is here (missing quote 1 and 3): https://docs.google.com/document/d/1JiyPgfWbhjJCFnEyrXTEdd1CXZ_vz3dj37FHbZCPWz4/edit?usp=sharing

The copy for Gary's story is here (missing quote 1 and 3):
https://docs.google.com/document/d/1Bxti8B3casqFMXRlsFcIewaFkqU2hVVnjG_ZXZyC7S4/edit

Plan

  • Update keys in CA repo
  • Then add copy

Paragraph with multiple links

Some of the content we want to add to the privacy policy requires multiple hyperlinks to external content which is currently not something we can do.

  • Is this worth implementing?

Logical Structure/Meaningful Sequence

Description

The layout of pages is conducive to a user seeking support. HTML5 use is generally semantic. A few potential exceptions are documented here:
- [ ] Use of headings for long Call To Action text can make the outline that a screenreader would use bloated. e.g.
image

  • Some sections, while made distinct with visual styling and HTML5 <section> tags, are left without headings. This leaves them invisible and unlabelled in the document outline. For each section, it should be considered as to whether they would be deserving of a place in the outline. e.g.
    • The information given after a story:
      image
    • The dates given within "When do sessions take place?"
  • Some areas may benefit from being explicitly ordered or marked as unordered, to aid screenreader navigation features. e.g. the footer is only sectioned with
    elements
    image

Add colours and fonts for Hospice Hope

Description

We need some Hospice Hope branding on the site. We have agreed with the client on this design
HospiceHope_Alt.pdf

Fonts

Body: Lato
Heading: Arial Rounded MT Bold (probably)

Colours

Brand blue: 00418F
Brand yellow: FEDD00
Text: 3C3C3B
Background white: FFFFFF
Background grey: F5F5F5
Background highlight blue: C8DDF6
Focus blue: 407EC9
Button hover yellow: FFEF82

Plan

  • Make sure it is accessible and inclusive. Do a sweep of the design
  • Implement colour palette as per Holly's design

Acceptance Criteria

  • Design looks and feels similar to Holly's design (copy on design pdf can be ignored)

Liz bugs and copy changes

Description

Liz has emailed over a couple of bugs and copy changes

Copy changes

  1. The “worried it’s not for me” page – the first sentence reads: "Lots of people tell us they’re worried that everyone here will be older than me." It should read “them” instead of “me”
  2. The the “Who comes to us” page states conditions such as 'Parkinson's, chronic fatigue or cancer', should be 'Parkinson's, heart failure or cancer'
  3. Any mention of 'day therapy' needs to be placed with 'day respite'
  4. Hazel and Colin’s story is missing a capital S where other stories have one

Bug fixes

  1. Odd space on the menu bar on mobile
    image

Plan

  • Update copy in code and master docs
  • Discuss menu bar

Change the reference to Therapy

"Therapy"

Two mentions of "therapy" survived:

  • In Gary's second picture
    image
  • In the alt text of Gary's third picture: Illustration of a confused man surrounded by thought bubbles. The bubbles contain Gary’s ideas of what Hope House was; there is a drawing of a therapy couch, two older people, a house and question marks.

Update meta, title, favicon etc

Description

The content in the <head> such as title, meta description and favicons should relate to Hospice Hope.

Plan

  • Source content for description and agreed title
  • Make a favicon
  • Update the title and description (they're in the head)
  • Analytics UA code

ca-218-CTA-styles

Plan

  • copy CallToActionTwo key to CallToActionThree key in brand copy.
  • edit CallToActionTwo key fields so that it displays the same info as it did before - the book icon and "hope Stories" etc
  • We also now have only two CTA actions, DesktopInteractive and DesktopDisplayOnly. ca-hh should want them all to be interactive.

Copy right url

Description

The copyright URL in the footer and multiple URLs in the privacy policy have no human-readable description; a screen reader would just have to read them out in full.

Plan

  • Step one to achieve this.
  • Step two to achieve this.

Get in contact page

Description

During our research we agreed that we want a form online so people can easily refer or ask questions

Preview of Typeform form: https://hospicehope.typeform.com/to/rGEewl

Plan

  • Embed form into its own page
  • Add copy for page:

If you'd like us to get in touch with you about Hope House or the Support Cafe, please give us a few details.

  • Check accessibility of form

Acceptance Criteria

  • Form submissions are received correctly
  • The form can be filled out

Update brand keys & brand style imports

Description

Sync the BrandKey.elm up with the Keys in core code - following the CA updates.

Plan

  • Make sure the Keys.elm and BrandKeys.elm have same values
  • Make sure the files we need to override are being included here

Header link on homepage

Description

  • The header stops being a link to the homepage on the homepage itself. This goes against the grain, as most websites preserve the link to provide a consistent "go to home" button and to allow for the homepage URL to be copied easily. (won't fix - but @Nikomus @roseb04 we should check if this is normal/ expected)

image

Update info sections

Description

Info connected to each story should be as follow

  • Shane: "2. What is Hope House?" and "1. Who comes to our sessions"
  • Hazel and Collin: "3. What are the support cafes?" and "4. worried it is not for you?"
  • Gary: "5. Cost and other practicalities?" and "6. When do sessions take place?"

Plan

  • Update associated info

Add Gary's Story

Description

Add Garys's Story to the app.

The copy for the story is here: https://docs.google.com/document/d/1Bxti8B3casqFMXRlsFcIewaFkqU2hVVnjG_ZXZyC7S4/edit?usp=sharing

Folder for illustrations: https://drive.google.com/drive/folders/1Y4yh39QEfzXcu1vHws2sNNCl8ZM4L_RK?usp=sharing

Plan

  • Add Keys with Copy to BrandCopy.elm
  • Add alt text if not there yet

Acceptance Criteria

Add Shane's Story

Description

Add Shane's Story to the app.

The copy for the story is here: https://docs.google.com/document/d/1JiyPgfWbhjJCFnEyrXTEdd1CXZ_vz3dj37FHbZCPWz4/edit?usp=sharing

Folder for illustrations: https://drive.google.com/drive/folders/1RuLvsbAliXFMyY0pvATFC8lsIl4Ht1Da?usp=sharing

Plan

  • Add copy
  • Add alt text

Acceptance Criteria

CSS pseudo-elements

Description

Quotes in stories are given their quotation marks with CSS pseudo-elements. This may not work smoothly with screenreaders.
image

Servers and domain names

Description

We need to think about servers and how we will do this. And to look at getting the domain name for Hospice Hope, we are currently thinking about calling it Hospice Hope Stories.

Plan

  • Find out how much it would cost for the domain name hospicehopestories.org.uk
  • How will we set them up a server for the site and hand it over?

Acceptance Criteria

  • We have set up a server and handed it over to Hospice Hope
  • We have a domain name for the site

Call to actions

Description

Call to actions are as follows:

  • Phone number - 01530 222079
  • 'Get in contact' button which leads to the form

Plan

  • Source icons for call to actions
  • call to actions
  • link 'get in contact' to page with embedded typeform

Acceptance Criteria

  • The telephone call to action is 01530 222079
  • The 'get in contact' call to action links to a page with an embedded form in it

Change 'call to actions' as headings

Description

Use of headings for long Call To Action text can make the outline that a screenreader would use bloated. e.g.
image

Plan

  • Step one to achieve this.
  • Step two to achieve this.

Browser testing and Screen Reader testing

Supported Browser List

Devices: iPhone, iPad, Android Phone, Windows Phone and desktop
Browsers: Stock Android, Chrome, Safari, Edge, Firefox (latest stable release)

We test on Specific Combinations:

  • Android 4+ Phone - Stock browser
  • Android 4+ Phone - Chrome browser
  • Android 4+ Phone - Firefox Focus browser
  • ipad iOS7+ - Safari browser
  • iphone 5 iOS7+ - Safari browser
  • iphone 6 iOS7+ - Safari browser
  • iphone 7 iOS7+ - Safari browser
  • Windows phone - EDGE browser @katja Is this still required?
  • Desktop - Chrome browser
  • Desktop - Firefox browser

Recommended Screen Reader and Browser Combinations

We may need to chat about how much time we spend on this

  • Windows: Internet Explorer and JAWS for Windows (JFW)
  • Windows: Firefox and NVDA
  • Mac: Safari and VoiceOver

Tabbing issues

Description

The order of tabbing is consistently good: the header, the navbar (whether at the top or bottom) and then the content.

Despite this, the site is not consistently amenable to tab-based navigation:

  • If the browser must scroll to reach the next keyboard-navigable element, it may be covered by the sticky navbar on small-viewport displays. e.g. The supporters link has been selected and automatically scrolled to but is obscured (on Firefox 68.0.2, Ubuntu 19.04).
    image
  • There is an empty link that must be tabbed past on the homepage. As it is not described, this would be especially confusing for users of screenreaders.
    image
  • There is an empty heading on the Privacy Policy page
    image

Scrollbar on small viewports

Description

  • In small viewports, with the navbar at the bottom, there is empty space to scroll to even when the page is not sufficiently large.

image

Link text

Description

Link text - The purpose of every link is clear from its text/context https://www.wuhcag.com/link-purpose-in-context/

Most links are clear and obvious (aside from the empty link that goes nowhere, as mentioned in Focus Order). There are still a few that are worth discussing:

  • In the cookie banner, "Accept" and "Decline" may not be obvious in their effect if read by a screenreader out of context. Links may be read out of context for speedy navigation, so this is not too uncommon a scenario.
  • "Show me the stories" and "Hope Stories" on the homepage have different descriptions but both link to the same (which is advised against in the guidelines of the website linked).
  • The copyright URL in the footer and multiple URLs in the privacy policy have no human-readable description; a screen reader would just have to read them out in full.

Accessibility testing

Description

Review the accessibility of the app

Basic Accessibility Checks

Intermediate Accessibility Checks

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.