neontribe / cottage-booking

Cottage Booking front end booking path using CanJS

NOTE: Issue tracking has been moved to jira.neontribe.co.uk

Cottage Booking Path using canJS

Versioning

I attempt to follow the Semver version ethos

Download dependencies

This doesn't work on windows, the nested node_modules exceeded max filename size

npm install
./node_modules/.bin/grunt develop
# optionally you could, so you could just do grunt develop
sudo npm install grunt-cli -g

Grunt tasks

Note: The release uses the same syntax as bumpup

# default grunt task is to build and create the prod.zip file
grunt

# buildViewFiles will build the view.js file used to
# manage the views for each control 
# ( see controls/form/views.js for a good example )
grunt buildViewFiles

# this will release and add a release to the releases 
# The release should include a zip of build production files
# TODO: add changelog
grunt release            # Default patch release
grunt release:minor      # Minor release
grunt release:minor:1458 # Minor release with buildtype suffix

Deployment

Take the prod.zip file and add it to the booking module

$ tree .
├── prod
│   └── prod.zip
├── templates
│    ├── booking_complete_email_customer.tpl.php
│    └── tabs_booking_payment_complete.tpl.php
├─── tabs_booking_payment_error.tpl.php
├── tabs_booking.admin.inc
├── TabsBookingBlocks.class.php
├── tabs_booking.booking.inc
├── tabs_booking.enquiry.inc
├── tabs_booking.info
├── tabs_booking.install
├── tabs_booking.metatag.inc
├── tabs_booking.module
├── tabs_booking.path.inc
├── TabsBookingSession.class.php
└── TabsBookingUtils.class.php

$ cd prod
$ wget -O prod.zip https://github.com/neontribe/cottage-booking/releases/download/<version>/prod.zip
$ unzip -o prod.zip
$ git commit -am 'Include javascript version <version>'
$ drush cc all

Tip n tricks

Connect the dev project to an existing drupal

/cottage-booking/app/cottage_booking.html?noFixture=1&apiRoot=http://localhost/zz/

Symlink the project into a drupal

tobias@tobias tabs_booking $ pwd
/var/www/html/zz/sites/all/modules/custom/nt_tabs/tabs_booking
tobias@tobias tabs_booking $ ll prod
lrwxrwxrwx 1 tobias tobias 57 Oct 23 10:21 prod -> /home/tobias/workspace/Cottaging/cottage-booking/app/prod/
tobias@tobias tabs_booking $ 

cottage-booking's Issues

Prev / Next accessibility

Previous and next links for calendars do not have hrefs and are consequently not focusable. Either add tabindex="0" or an href with dummy value.

Support pay later button

This will require some back end work in https://github.com/neontribe/NeonTABS/tree/master/neontabs_includes/modules/tocc-dr/dr_tabs/tabs_booking

Add number of people on first stage calendar

display errors as inline markup rather than tooltips

so html

<div>
    <label for="username">Your username</label>
    <input class="errors" type="text" id="username" aria-describedby="username-tip" >
    <div role="tooltip" id="username-tip">There is an error</div>
</div>

:input.errors + [role="tooltip"] {
    display: none;
}
:input.errors:focus + [role="tooltip"] {
    display: block;
}

Fix setting base url

Make option merge from outside the app work

So we can instantiate the app with some settings.

Change module endpoints to https:// in places

add option to display as accordion instead of tabs

Add change log to tagged releases.

Add easier navigation of the sources list

Like an autocomplete or a couple of selects which react to each other.

Add button to populate party details traveller 1 with customer details

Improve documentation, so that it can be dropped into something like documentjs

https://github.com/bitovi/documentjs/
https://github.com/p120ph37/node-jsdoc-toolkit

Show the state of ajax requests

• disable the book now button while booking
• show a spinner

More tests!

Write ~30 tests

Negative amount due!

Improve validation on booking details

Investigate why paymentType isn't maintained between booking saves

For example: on the payment screen if we switch payment type, the store in booking.price.paymentType is lost. ( noFixture=1 )

Add book now button onto calendar

Dur

Finish writing the status control

The controller needs to

• auto save when the user is idle
• display errors and spinner
• Display "saved at" time

Complete confirmation page

Add pretty things to the confirmation page.

Start date -> number of days on the calendar page

Use Tabs generated sources list

For the source and which fields

Investigate payments making the amount due negative.

Improve payment error/complete pages with examples as their default templates

This will need to be completed at:
https://github.com/neontribe/NeonTABS/tree/master/neontabs_includes/modules/tocc-dr/dr_tabs/tabs_booking/templates

Fix bad post to [object Object]/...

When we save the payment model with empty party details we try and post to the wrong place.

Update grunt so that we can update and bump versions etc

https://github.com/darsain/grunt-tagrelease#usage-examples
https://github.com/darsain/grunt-bumpup

Investigate maintaining booking details between different dates