GithubHelp home page GithubHelp logo

Comments (9)

kamilmysliwiec avatar kamilmysliwiec commented on April 28, 2024 3

Fixed in 2.0.2

from mapped-types.

Keeper991 avatar Keeper991 commented on April 28, 2024 2

https://github.com/Keeper991/partial-type-issue/blob/master/src/app.service.ts

ChildClass inherits ParentClass with PartialType, and tried to push partial object in ChildClass Array(line:16).
but ts throws an error message 'missing the following properties from type 'ChildClass': age, job'.

from mapped-types.

vincent-ogury avatar vincent-ogury commented on April 28, 2024 1

@micalevisk did the example above help ? it show the problem immediately.

from mapped-types.

micalevisk avatar micalevisk commented on April 28, 2024 1

thanks!

that was a regression introduced by PR #1027 on v2.0.0

from mapped-types.

micalevisk avatar micalevisk commented on April 28, 2024 1

and that's due to your strictNullChecks being false btw

which breaks the following utility:

type KeysOfType<T, U> = { [K in keyof T]: T[K] extends U ? K : never }[keyof T];

from mapped-types.

Keeper991 avatar Keeper991 commented on April 28, 2024

I faced the same problem. There is a problem in that the properties of the instance of the class inherited as a partial type are not guided to optional. 🥲

from mapped-types.

micalevisk avatar micalevisk commented on April 28, 2024

@Keeper991 do you mind on sharing a minimum reproduction repository? it would help us to fix that quickly

from mapped-types.

micalevisk avatar micalevisk commented on April 28, 2024

@vincent-ogury
@celogeek

minimum reproduction repository

(note the repository part)

please don't spam. That doesn't help on fixing the issue. Also, you guys could investigate why that bug exists and try to fix that as well :)

from mapped-types.

micalevisk avatar micalevisk commented on April 28, 2024

@vincent-ogury

why reproductions are required

from mapped-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.