GithubHelp home page GithubHelp logo

Comments (5)

KuanWenChen avatar KuanWenChen commented on April 28, 2024 1

OK, I think I found the problem.
_excludeMetadatas, _exposeMetadatas, _typeMetadatas should not be a Array
So, they should be overwriten by children.
I would create PR as soon as.

from mapped-types.

vsamofal avatar vsamofal commented on April 28, 2024

@KuanWenChen probably you can take a look, I understand that you were fixing something, but we also break some, so need to come up with some plan for all known cases to work

from mapped-types.

KuanWenChen avatar KuanWenChen commented on April 28, 2024

I thing problem is happen at value is not a iterable type. I am not sure why value is not a iterable type.
I thing this could fix it:

[existingRules, targetMetadataEntries].forEach((entries) => {
  for (const [valueKey, value] of entries) {
    const arrayValue = Array.isArray(value) ? value : [value];
    if (mergeMap.has(valueKey)) {
      mergeMap.get(valueKey)!.push(...arrayValue);
    } else {
      mergeMap.set(valueKey, arrayValue);
    }
  }
});

from mapped-types.

kamilmysliwiec avatar kamilmysliwiec commented on April 28, 2024

Could you create a PR for this issue?

from mapped-types.

kamilmysliwiec avatar kamilmysliwiec commented on April 28, 2024

Let's track this here #1225

from mapped-types.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.