Comments (5)
Can get around this by doing NestExpressApplication
instead of INestAppliction
or INestApplication<NestExpressApplication>
from nest.
so the "issue" is because app.getHttpServer()
has any
as the return type, right?
I guess that's because of the following change: cf4097c
now INestApplication
has a type arg, which defaults to any
I'm not sure if we can improve that or if you just need to type that INestApplication
better
from nest.
Well, how would I type the INestApplication
better than doing INestApplication<NestExpressApplication>
? I don't think there is anything else that would make sense in the context that it is being used.
i.e. the error occurs still with INestApplication<NestExpressApplication>
Edit:
Actually, a different error is encountered
from nest.
It should be: INestApplication<Server>
where Server
is from net
(nodejs module)
Still, I'm not sure if we can improve the typings of createNestApplication
but I'd suggest you to try to improve it.
So this is not a bug but a feature request
from nest.
Just pass <Server>
as a type argument, as @micalevisk suggested above
When it comes to your ESLint rule, this isn't a bug (more explanation here nestjs/schematics#1700 (comment))
One thing we could improve is to mention this in the docs (if you have X rule enabled, then make sure to pass Server as a type argument).
from nest.
Related Issues (20)
- Allow readonly arrays as providers, imports, etc. HOT 3
- Validation fails in RPC context for MqttContext HOT 6
- Only the last APP_FILTER providers works HOT 4
- dependency injection does not work. HOT 3
- gRPC Streaming endpoints that throw errors crash the main process HOT 2
- Injectable instances can have references to Request objects and can hold it forewer in request scope
- Middleware consumer have a text error HOT 3
- Extra options are set only to default values when using `registerAsync` HOT 2
- Can we have a template resource for graphql + rest together? HOT 5
- Connection Error in Service during Startup HOT 2
- Wrong type (as in #12264) HOT 3
- Nest CLI generates the wrong package.json file HOT 8
- Watch mode is broken HOT 1
- Hyphens in parameters silently fail HOT 4
- Improve documentation on @Injectable() HOT 2
- Log is not auto-flushed on error during initialization HOT 1
- Middleware not executed when using `exclude` in `setGlobalPrefix` HOT 2
- The use of SetMetadata custom decorators does not take effect HOT 13
- NestJS HttpException class returns success status when status is undefined HOT 4
- NestJs DI `useFactory` ignores property dependencies HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nest.