netgroup-polito / mdo2frog4 Goto Github PK

1. Write a short text in the main readme about examples, and move the documentation of the examples in the proper folders.
2. Why there are more examples (.e., XML) than the documented ones?

It is not clear to me.
If you go in that folder, it seems it has to be installed.
However, the main readme file doesn't report that info.
What should we do?

What is this for?
Btw, why is the maintainer "Pontus Skoldstrom [email protected]"?

I suggest to not use print on the project but to use the logging python class that helps to generate a log file.

The repository contains a lot of compiled files (.pyc), it is better to remove them and use a .gitignore file to avoid to deploy them again.
The main and only file of the project contains a lot of commented lines, it is better to remove the ones not used anymore.

Please explain. If no reasons are there, delete them from the repo and add them as submodules.

The readme has wrong unused requirements to install (various C libraries).
It also specifies to use ubuntu 14.04, but it should be python and it should be compatible with the latest version of ubuntu.

The "universal node" term is used in several places, also in the code (e.g., virtualizer.py).
Remove it, as we're controlling a generic FROG4 domain, not just the universal node.

When a graph is sent to the frog4-orchestrator, the mdo2frog4 authenticate itself and then try to send the graph through a PUT to the /NF-FG resource, receiveing a 405 http bad response.
However based on the frog4-orchestrator REST api, the only http methods allowed are:

1. POST /NF-FG
2. PUT /NF-FG/{nffg_id}