netlify-templates / gatsby-ecommerce-theme Goto Github PK

currently some links link to shop and some don't
we've decided to just add it everywhere for consistency
if the link is /shop and user is currently on the /shop page nothing will happen
we'll clarify this in the readme

Summary

We want to make sure our formatting is consistent so we like to add a nice little tooling for us. Previously in other projects we've opted for Prettier and and ESLint. We don't have a significant amount of opinions but we try to optimize for the project/framework's own opinions.

Maybe something like this, https://www.gatsbyjs.com/docs/how-to/custom-configuration/eslint/, could be helpful for building a base eslint configuration for a Gatsby site. I think the prettier file is just including a .prettierrc file. See this document on installing it

Currently running into an issue where on certain pages we are seeing double footer and page only on the Deployed site and not locally.

[![Deploy to Netlify Button](https://www.netlify.com/img/deploy/button.svg)](https://app.netlify.com/start/deploy?repository=https://github.com/netlify-templates/gatsby-ecommerce-theme)

Summary

As a keyboard user, I should be able to see the card and use the TAB and SHIFT+TAB combination to focus along each as a link

these eslint a11y errors came up because of more instances of using divs instead of buttons. we shuold make these anchors or buttons instead.

/gatsby-ecommerce-theme/src/components/BlogPreview/BlogPreview.js
  14:5  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events
  14:5  warning  Static HTML elements with event handlers require a role                                         jsx-a11y/no-static-element-interactions

gatsby-ecommerce-theme/src/components/Swatch/Swatch.js
  8:5  warning  Visible, non-interactive elements with click handlers must have at least one keyboard listener  jsx-a11y/click-events-have-key-events
  8:5  warning  Static HTML elements with event handlers require a role                                         jsx-a11y/no-static-element-interactions```

Summary

I was verifying that the buttons and things were working on smaller devices and found these interesting visual defects. My suspicion is that they illuminated themselves when I modified these elements into buttons instead of divs.

Tablet	Phone

I couldn't see these on a desktop even in the visual responsive modes so I am glad that I have test devices to verify any new behavior.

Summary

The iconography in the navigation needs to be accessible and reachable for users. Right now they do not communicate the appropriate behavior even though they work for mouse users. I think optimizing them for semantic HTML will be ideal.

Currently everything in this except for the lefthand navigation is considered a div

Summary

Under the Sustainability section in the /product/sample route, this link leads to /blogs and should go to /blog instead.

• how to install
• instructions on how to develop locally w netlify dev

Summary

To make sure that our project stays up to date we'd like to add some tools:

• Cypress integration (for testing e2e, ref doc here)
• Renovate (for dependency management)
  add 'renovate.json` to project root

  {
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": [
      "local>netlify-templates/renovate-config"
    ]
  }
  

• Disable dependabot secutrity and version update alerts
• Make sure to update the README on how to remove everything
  • add section on cypress removal
  • add section on removing renovate json file
  • add comment at top of renovate json saying it can be removed if not using renovate

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• Update dependency netlify-plugin-cypress to ~2.2.1
• Update dependency cypress to v13
• Update dependency plop to v4
• Update dependency prettier to v3
• Update gatsby monorepo to v5 (major) (gatsby, gatsby-plugin-manifest)
• Click on this checkbox to rebase all open PRs at once

Detected dependencies

• Check this box to trigger a request for Renovate to run again on this repository

• #3
• clean up side nav links
• #7

Jdhduh

• to netlify.toml (https://docs.netlify.com/integrations/build-plugins/#configure-settings)
• to README

guide to

• CLI deployment
• UI deployment
• DTN button

Deeper into the workings

• file structure
• how to make changes (we should figure out a way to keep this "lite" e.g. config.json changes, header, footer, and homepage changes)
• what tools to use to add functionality (link to https://matterdesign.com.au/service/headless-commerce-with-jamm/ and also list other tools that can be used like Shopify, Stripe, etc.)

feel free to use https://github.com/netlify-templates/nextjs-blog-theme as a guide

• add project overview description emphasizing that it is a theme
• what tools are used
• screenshot

Ghdbgf

After cloning and running 'npm i', I did npm start and I got the following error

[email protected] start
gatsby develop -p 5000

internal/modules/cjs/loader.js:491
throw new ERR_PACKAGE_PATH_NOT_EXPORTED(basePath, mappingKey);
^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './is-truthy' is not defined by "exports" in /Applications/gatsby-ecommerce-theme/node_modules/gatsby-core-utils/package.json
at applyExports (internal/modules/cjs/loader.js:491:9)
at resolveExports (internal/modules/cjs/loader.js:507:23)
at Function.Module._findPath (internal/modules/cjs/loader.js:635:31)
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:953:27)
at Function.Module._load (internal/modules/cjs/loader.js:842:27)
at Module.require (internal/modules/cjs/loader.js:1026:19)
at require (internal/modules/cjs/helpers.js:72:18)
at Object. (/Applications/gatsby-ecommerce-theme/node_modules/gatsby-cli/lib/reporter/reporter.js:34:17)
at Module._compile (internal/modules/cjs/loader.js:1138:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10) {
code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

When running gatsby build
/usr/local/lib/node_modules/gatsby-cli/lib/reporter/reporter.js:41
let isVerbose = (0, _isTruthy.isTruthy)(process.env.GATSBY_REPORTER_ISVERBOSE);
^

ReferenceError: _isTruthy is not defined
at Object. (/usr/local/lib/node_modules/gatsby-cli/lib/reporter/reporter.js:41:17)
at Module._compile (internal/modules/cjs/loader.js:1138:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
at Module.load (internal/modules/cjs/loader.js:986:32)
at Function.Module._load (internal/modules/cjs/loader.js:879:14)
at Module.require (internal/modules/cjs/loader.js:1026:19)
at require (internal/modules/cjs/helpers.js:72:18)
at Object. (/usr/local/lib/node_modules/gatsby-cli/lib/reporter/catch-exit-signals.js:16:17)
at Module._compile (internal/modules/cjs/loader.js:1138:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)