Comments (8)
Yeah, sorry for the late reply. I think this is fine.
from nir.
I agree that this is slightly misleading.
Our current implementation is similar to the torch.nn.Sequential of Pytorch. Tensorflow's tf.keras.Sequential is similar to your first suggestion with the lists.
I like the idea of renaming to Sequential and keeping the definition otherwise as is.
from nir.
Nicely spotted! That's my bad. I really like avoiding the two [ ]
characters :P
How about adding a check so we can work with both lists and varargs? That's also what PyTorch is doing, I believe.
from nir.
I would also prefer renaming it to Sequential
and passing the args without container.
Pytorch (at least my possibly outdated version) raises an error when passing a list:
TypeError: list is not a Module subclass
I also don't mind supporting both, though.
from nir.
This should be fixed with #50. Would you mind confirming and closing, @bauerfe ?
from nir.
I'm really sorry but I must be missing something. Could you please specify how #50 addresses this issue? Neither the name nor the call signature of the from_list
method has changed.
from nir.
You're entirely correct that the PR doesn't change the name of the method. But it allows the from_list
method to take a list and varargs (
Line 44 in 464de9f
from_list
doesn't even take lists.
I'm sympathetic if you wish to rename the method if you think there's a better name. I believe you suggested sequence
or compose
?
from nir.
@bauerfe could you share your opinion on how to proceed? Is the current naming sufficient, given #50?
from nir.
Related Issues (20)
- Notebook docs run with wrong dependencies
- Neuron parameters shift in nir_to_lava script HOT 3
- black and docformatter conflict.
- Discrepancy between Readme and docs on supported projects HOT 4
- Unify version tag and automate release
- IR for SumPool2d
- Poor code design pattern for serializing/deserializing HOT 2
- Disambiguation input/output shapes HOT 5
- Conv2D misleading default input_type and output_type HOT 1
- Remove input_shape from Conv1d/2d
- Flatten input_type is not necessary HOT 2
- Suggestion: add input_type argument to nir.from_list
- infer_type fails with Tuple index out of range error. HOT 9
- meta-data in NIR nodes HOT 3
- LICENSE mismatch HOT 3
- Add AvgPool2D
- Backwards-compatibility of imports broken after refactoring HOT 1
- 'int' object has no attribute 'item' on conv shapes calculation HOT 5
- Remove notebooks and paper data from pypi release HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nir.