Comments (2)
I see your point, but it might also be useful to leave it to keep NIR explicit and expressive. Any other opinions?
(no rush on this, we can resolve this after the initial paper submission)
from nir.
As long as the graph has an Input with a given shape, the infer_shapes is able to determine the shapes, so I think the same goes as for any other layer, that we do not need to store the input_type.
I believe our consensus was that we do not store unnecessary information. But of course, the infer_shapes can and will determine the input_type of the Flatten layer. Therefore I do not think removing the field (I am only talking about the explicit field, not the one set by post_init) does not make NIR less expressive.
from nir.
Related Issues (20)
- Notebook docs run with wrong dependencies
- Comparison of two nodes fails HOT 8
- black and docformatter conflict.
- Discrepancy between Readme and docs on supported projects HOT 4
- Misleading method name `from_list` HOT 8
- Unify version tag and automate release
- IR for SumPool2d
- Poor code design pattern for serializing/deserializing HOT 2
- Disambiguation input/output shapes HOT 5
- Conv2D misleading default input_type and output_type HOT 1
- Remove input_shape from Conv1d/2d
- Suggestion: add input_type argument to nir.from_list
- infer_type fails with Tuple index out of range error. HOT 9
- meta-data in NIR nodes HOT 3
- LICENSE mismatch HOT 3
- Add AvgPool2D
- Backwards-compatibility of imports broken after refactoring HOT 1
- 'int' object has no attribute 'item' on conv shapes calculation HOT 5
- Remove notebooks and paper data from pypi release HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nir.