automatic installation doesn't pick up dependencies in setup.py about ephypype

[davidmeunier79]

I have done a packaging of the current version of ephypype (no problem with the version for me...) . Can someone have a try at a pip install ephypype?

Should be version ephypype-0.1.dev0

https://pypi.org/project/ephypype/

[dmalt]

Ok!

[annapasca]

Hi Dima, about installation I think we have to install by pip, is it @davidmeunier79 @jasmainak @EtienneCmb ?

[dmalt]

@annapasca, you mean without cloning it from github like this

pip install ephipype

?

[annapasca]

In the neuropycon channel of slack I read David tried to create a package for graphpype

[dmalt]

Hi, @annapasca! What I'm trying to say is that when installing ephypype with pip
the requirements from the install_requires list in setup.py should be installed automatically but it doesn't happen because we import ephypype package first. This is part of setup.py:

#!/usr/bin/env python
# -*- coding: utf-8 -*-
"""Setup configuration."""

from setuptools import setup, find_packages
import ephypype

VERSION = ephypype.__version__

if __name__ == "__main__":
    setup(...)

It's easy to fix by commenting out the import ephypype line but I'm not sure what to do with the VERSION. Do we need to keep it inside the init.py file?

[davidmeunier79]

Yes there is a self referencing loop here that does not appear to be normal... For graphpype the version needs to be set by hands, but do not involve a previous round of install. Maybe you can suppress both import ephypype and VERSION and set the version by hand at the moment?

[dmalt]

@davidmeunier79, ok, I'll go with that.

[davidmeunier79]

Can you let me know once it is done? I will try to post a version on pip repo after that

[dmalt]

I just tried to install ephypype in a clean environment with pip install ephypype and the installation went fine.
When I tried to import ephypype though it complained about missing the matplotlib package which is caused by mne. But here the problem is not on our side I think.

[dmalt]

@davidmeunier79 I just pushed a new setup.py if it's still relevant.

[annapasca]

@dmalt can you make a PR to merge the setup? Furthermore can you insert

install_requires=['mne>=0.16',

thks!

[dmalt]

Pull request is there: #23

[davidmeunier79]

done

[jasmainak]

agreed there was a bug.

But the pull request still does not fix the issue