GithubHelp home page GithubHelp logo

neverbounceapi-go's People

Contributors

enkhalifapro avatar georgenov avatar mmollick avatar somprabhsharma avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

neverbounceapi-go's Issues

gopkg.in/jarcoal/httpmock.v1 currently breaks application using NeverbounceApi-Go

My application is using the go wrapper of neverbounce API, but after upgrading from go 1.12 to go 1.15 the build fails (even when I call go mod tidy) because of httpmock.v1 dependency. The error is:

github.com/NeverBounce/NeverBounceApi-Go tested by
github.com/NeverBounce/NeverBounceApi-Go.test imports
gopkg.in/jarcoal/httpmock.v1: no matching versions for query "latest"

Even when I call manually go get gopkg.in/jarcoal/httpmock.v1 the result will be the same.

The issue could be resolved by replacing the imports of httpmock.v1 from gopkg.in/jarcoal/httpmock.v1 to github.com/jarcoal/httpmock. Also would be worth to add go.mod to the package.
Do you think it's feasible? Or do you have any other suggestion for resolving this issue?

Add support for passing an http client to single check

Problem:
After integrating neverbounce we're experience that some requests take a lot longer (upwards to the limit of 10s we defined), for that reason, we want to use a custom http client instrumented with AWS X-Ray to be able to get more insights on which requests take longer.

The proposed solution would allow users to instrument the http client freely, and it would probably make sense to extend that behaviour to the other apis (though we don't require it at the moment).

Is this change something you would be willing to work on or accept Pull Requests for?

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.