`clusterName` metric attribute collides with Kubernetes'

Description

HAProxy integration writes the name of the HAProxy cluster as a clusterName attribute in metrics. However, this label is also used by the Kubernetes integrations to annotate the Cluster name in which an integration is running. This causes the latter to shadow the former.

Expected Behavior

HAproxy ClusterName and Kubernetes ClusterName should be reported as different attributes.

Steps to Reproduce

Run the HAProxy integration in Kubernetes.

Docker error "Couldn't load integration instances from config file"

Hi

I kept getting the following error when trying out docker image newrelic/k8s-nri-haproxy:2.1.0:

"Couldn't load integration instances from config file" component=PluginRegistry configFile=haproxy-config.yml error="Integration definition not found" integration=com.newrelic.haproxy

Had to import the definition to another directory for newrelic-infrastructure to pick it up: /var/db/newrelic-infra/custom-integrations/haproxy-definition.yml
This should be changed in:

nri-haproxy/Dockerfile

Line 11 in 10f8472

 COPY --from=builder /go/src/github.com/newrelic/nri-haproxy/haproxy-definition.yml /nri-sidecar/newrelic-infra/newrelic-integrations/definition.yml 

Also, the path to the sidecar in the already included definition appears not to work unless changed from ./bin/nri-haproxy to the absolute path /nri-sidecar/newrelic-infra/newrelic-integrations/bin/nri-haproxy

After these changed, it worked for me. Is there a better way to do this?

Thanks!
--Ariel

[Repolinter] Open Source Policy Issues

Repolinter Report

🤖This issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.

This Repolinter run generated the following results:

❗ Error	❌ Fail	⚠️ Warn	✅ Pass	Ignored	Total
0	0	0	7	0	7

Passed

Passed #

Click to see rules

✅ `license-file-exists` #

Found file (LICENSE). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.

✅ `readme-file-exists` #

Found file (README.md). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.

✅ `readme-starts-with-community-plus-header` #

The first 5 lines contain all of the requested patterns. (README.md). The README of a community plus project should have a community plus header at the start of the README. If you already have a community plus header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/.

✅ `readme-contains-link-to-security-policy` #

Contains a link to the security policy for this repository (README.md). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy or ../../security/policy) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.

✅ `readme-contains-forum-topic` #

Contains a link to the appropriate forum.newrelic.com topic (README.md). New Relic recommends directly linking the your appropriate forum.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.

✅ `code-of-conduct-should-not-exist-here` #

New Relic has moved the CODE_OF_CONDUCT file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT file in a repository is now redundant and should be removed. Note that you will need to adjust any links to the local CODE_OF_CONDUCT file in your documentation to point to the central file (README and CONTRIBUTING will probably have links that need updating). For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Did not find a file matching the specified patterns. All files passed this test.

✅ `third-party-notices-file-exists` #

Found file (THIRD_PARTY_NOTICES.md). A THIRD_PARTY_NOTICES.md file can be present in your repository to grant attribution to all dependencies being used by this project. This document is necessary if you are using third-party source code in your project, with the exception of code referenced outside the project's compiled/bundled binary (ex. some Java projects require modules to be pre-installed in the classpath, outside the project binary and therefore outside the scope of the THIRD_PARTY_NOTICES). Please review your project's dependencies and create a THIRD_PARTY_NOTICES.md file if necessary. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.

[Repolinter] Open Source Policy Issues

Repolinter Report

🤖This issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.

This Repolinter run generated the following results:

❗ Error	❌ Fail	⚠️ Warn	✅ Pass	Ignored	Total
0	2	0	5	0	7

Fail
- ❌ readme-starts-with-community-plus-header
- ❌ code-of-conduct-file-does-not-exist
Passed

Fail #

❌ `readme-starts-with-community-plus-header` #

The README of a community plus project should have a community plus header at the start of the README. If you already have a community plus header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/. Below is a list of files or patterns that failed:

README.md: The first 5 lines do not contain the pattern(s): Open source Community Plus header (see https://opensource.newrelic.com/oss-category).
- 🔨 Suggested Fix: prepend [![Community Plus header](https://github.com/newrelic/opensource-website/raw/master/src/images/categories/Community_Plus.png)](https://opensource.newrelic.com/oss-category/#community-plus) to file

❌ `code-of-conduct-file-does-not-exist` #

New Relic has moved the CODE_OF_CONDUCT file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT file in a repository is now redundant and should be removed. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Found files. Below is a list of files or patterns that failed:

CODE_OF_CONDUCT.md
- 🔨 Suggested Fix: Remove file

Passed #

Click to see rules

✅ `license-file-exists` #

Found file (LICENSE). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.

✅ `readme-file-exists` #

Found file (README.md). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.

✅ `readme-contains-link-to-security-policy` #

Contains a link to the security policy for this repository (README.md). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy or ../../security/policy) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.

✅ `readme-contains-discuss-topic` #

Contains a link to the appropriate discuss.newrelic.com topic (README.md). New Relic recommends directly linking the your appropriate discuss.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.

✅ `third-party-notices-file-exists` #

Found file (THIRD_PARTY_NOTICES.md). A THIRD_PARTY_NOTICES.md file can be present in your repository to grant attribution to all dependencies being used by this project. This document is necessary if you are using third-party source code in your project, with the exception of code referenced outside the project's compiled/bundled binary (ex. some Java projects require modules to be pre-installed in the classpath, outside the project binary and therefore outside the scope of the THIRD_PARTY_NOTICES). Please review your project's dependencies and create a THIRD_PARTY_NOTICES.md file if necessary. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.

Add semgrep and infra-checkers Github Actions

Improve static analysis with Semgrep adding the newrelic-infra-checkers actions to get the semgrep and golangci-lint configurations.

`haproxyClusterName` is not translated to DM format

Description

In #29 we introduced the haproxyClusterName attribute, but it was never added to spec files. Therefore, customers using metric queries will not be able to access it.

We should add it to the spec file and shim it as haproxy.clusterName.

Thanks @jlegoff for noticing this!

[Bug] Metric backend.averageTotalSessionTimeInSeconds unit issue

Description

Metric backend.averageTotalSessionTimeInSeconds is showing a value measured in milliseconds, not seconds.

This metric seems to be sourced from the HAProxy stats page, under Backend > Sessions > Total > Max / Avg over last 1024 success. conn. > Total > Avg which is labeled with ms unit and matches our stored metrics in NRDB for backend.averageTotalSessionTimeInSeconds.

Expected Behavior

Metric unit should match its name

Steps to Reproduce

Install nri-haproxy and the infra agent
Install HAProxy
Compare the stats page (http://localhost:2022/stats) with the backend.averageTotalSessionTimeInSeconds metric.

Your Environment

HaProxy Community Edition Version: 2.7.6
newrelic-infra-1.45.0-1.el8.x86_64
nri-haproxy-2.5.0-1.x86_64

Additional context

Support case #00142225

[ERR] Must supply a cluster name to identify this HAProxy instance as of 2.0.0

My YAML config file matches the format of the example in this repo
There's no mention of a cluster name at https://docs.newrelic.com/docs/integrations/host-integrations/host-integrations-list/haproxy-monitoring-integration

I guessed at adding a cluster_name entry to my YAML config file and it appears to work so hey lucky me! Do I get a discount on my next bill for fixing this myself?

Update nri-haproxy to last skd v3 version to fix the multi-instance storage collision

The nri-haproxy SDK shoud by updated to the last v3 version where the cache file is unique per instance to fix the multi-instance storage collision.

Metric type mismatch for `chkdown`

Description

According the HAProxy official documentation, the metric chkdown is a counter that return the number of up->down transitions for each backend.

Quote:

chkdown [..BS]: number of UP->DOWN transitions. The backend counter counts
transitions to the whole backend being down, rather than the sum of the
counters for each server.

Expected Behavior

Based on the definition of metric types from infra-integrations-sdk, I believe this metric type should be of type GAUGE instead of PRATE and its description should reflect that change e.g. from "upToDownTransitionsPerSecond" to "upToDownTransitions".

Troubleshooting or NR Diag results

N/A

Steps to Reproduce

N/A

Your Environment

N/A

Additional context

N/A

For Maintainers Only or Hero Triaging this bug

Suggested Priority (P1,P2,P3,P4,P5):
Suggested T-Shirt size (S, M, L, XL, Unknown):

Add option to skip SSL certificate validation when using HTTPS based STATS_URL

Hi

We use HTTPS with our stats page and allow access to it only from internal network.
So our certificate appears invalid when we access HAProxy stats page
In other cases, we use use self signed cert.

However, the plugin fails to collect stats with following error
Failed to retrieve stats: Get \"https://10.11.100.99:8000/stats;csv;norefresh\": x509: cannot validate certificate <HIDDEN> 10.11.100.99 because it doesn't contain any IP SANs"

Would it be possible to add an option to skip cert validation when STATS_PAGE contains HTTPS URL:
example:

STATS_PAGE=https://10.11.100.99:8000/stats
SKIP_CERT_VALIDATION="true"

Support collecting data through HAProxy socket

Is your feature request related to a problem? Please describe.

For security reasons and to align with their existing setup some customers prefer not to enable the stats page and would like to be able to monitor HAProxy via the socket connection

Feature Description

Config option to collect info via the socket instead of stats page

Additional context

This mode is supported by most of our competitors and is considered to be the "standard" way to do this for scripts and monitoring solutions.

Priority

Nice to Have

New release to include last supported Linux versions

The infra agent now supports:

Amazon Linux 2022 (Public Preview, GA expected by ~July)
RHEL 9 (GA)
Ubuntu 22.04 (GA)

[Repolinter] Open Source Policy Issues

Repolinter Report

🤖This issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.

This Repolinter run generated the following results:

❗ Error	❌ Fail	⚠️ Warn	✅ Pass	Ignored	Total
0	0	0	7	0	7

Passed

Passed #

Click to see rules

✅ `license-file-exists` #

Found file (LICENSE). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.

✅ `readme-file-exists` #

Found file (README.md). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.

✅ `readme-starts-with-community-plus-header` #

The first 5 lines contain all of the requested patterns. (README.md). The README of a community plus project should have a community plus header at the start of the README. If you already have a community plus header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/.

✅ `readme-contains-link-to-security-policy` #

Contains a link to the security policy for this repository (README.md). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy or ../../security/policy) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.

✅ `readme-contains-discuss-topic` #

Contains a link to the appropriate discuss.newrelic.com topic (README.md). New Relic recommends directly linking the your appropriate discuss.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.

✅ `code-of-conduct-should-not-exist-here` #

New Relic has moved the CODE_OF_CONDUCT file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT file in a repository is now redundant and should be removed. Note that you will need to adjust any links to the local CODE_OF_CONDUCT file in your documentation to point to the central file (README and CONTRIBUTING will probably have links that need updating). For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Did not find a file matching the specified patterns. All files passed this test.

✅ `third-party-notices-file-exists` #

Found file (THIRD_PARTY_NOTICES.md). A THIRD_PARTY_NOTICES.md file can be present in your repository to grant attribution to all dependencies being used by this project. This document is necessary if you are using third-party source code in your project, with the exception of code referenced outside the project's compiled/bundled binary (ex. some Java projects require modules to be pre-installed in the classpath, outside the project binary and therefore outside the scope of the THIRD_PARTY_NOTICES). Please review your project's dependencies and create a THIRD_PARTY_NOTICES.md file if necessary. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.

[Repolinter] Open Source Policy Issues

Repolinter Report

🤖This issue was automatically generated by repolinter-action, developed by the Open Source and Developer Advocacy team at New Relic. This issue will be automatically updated or closed when changes are pushed. If you have any problems with this tool, please feel free to open a GitHub issue or give us a ping in #help-opensource.

This Repolinter run generated the following results:

❗ Error	❌ Fail	⚠️ Warn	✅ Pass	Ignored	Total
0	0	0	7	0	7

Passed

Passed #

Click to see rules

✅ `license-file-exists` #

Found file (LICENSE). New Relic requires that all open source projects have an associated license contained within the project. This license must be permissive (e.g. non-viral or copyleft), and we recommend Apache 2.0 for most use cases. For more information please visit https://docs.google.com/document/d/1vML4aY_czsY0URu2yiP3xLAKYufNrKsc7o4kjuegpDw/edit.

✅ `readme-file-exists` #

Found file (README.md). New Relic requires a README file in all projects. This README should give a general overview of the project, and should point to additional resources (security, contributing, etc.) where developers and users can learn further. For more information please visit https://github.com/newrelic/open-by-default.

✅ `readme-starts-with-community-plus-header` #

The first 5 lines contain all of the requested patterns. (README.md). The README of a community plus project should have a community plus header at the start of the README. If you already have a community plus header and this rule is failing, your header may be out of date, and you should update your header with the suggested one below. For more information please visit https://opensource.newrelic.com/oss-category/.

✅ `readme-contains-link-to-security-policy` #

Contains a link to the security policy for this repository (README.md). New Relic recommends putting a link to the open source security policy for your project (https://github.com/newrelic/<repo-name>/security/policy or ../../security/policy) in the README. For an example of this, please see the "a note about vulnerabilities" section of the Open By Default repository. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.

✅ `readme-contains-discuss-topic` #

Contains a link to the appropriate discuss.newrelic.com topic (README.md). New Relic recommends directly linking the your appropriate discuss.newrelic.com topic in the README, allowing developer an alternate method of getting support. For more information please visit https://nerdlife.datanerd.us/new-relic/security-guidelines-for-publishing-source-code.

✅ `code-of-conduct-should-not-exist-here` #

New Relic has moved the CODE_OF_CONDUCT file to a centralized location where it is referenced automatically by every repository in the New Relic organization. Because of this change, any other CODE_OF_CONDUCT file in a repository is now redundant and should be removed. Note that you will need to adjust any links to the local CODE_OF_CONDUCT file in your documentation to point to the central file (README and CONTRIBUTING will probably have links that need updating). For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view. Did not find a file matching the specified patterns. All files passed this test.

✅ `third-party-notices-file-exists` #

Found file (THIRD_PARTY_NOTICES.md). A THIRD_PARTY_NOTICES.md file can be present in your repository to grant attribution to all dependencies being used by this project. This document is necessary if you are using third-party source code in your project, with the exception of code referenced outside the project's compiled/bundled binary (ex. some Java projects require modules to be pre-installed in the classpath, outside the project binary and therefore outside the scope of the THIRD_PARTY_NOTICES). Please review your project's dependencies and create a THIRD_PARTY_NOTICES.md file if necessary. For JavaScript projects, you can generate this file using the oss-cli. For more information please visit https://docs.google.com/document/d/1y644Pwi82kasNP5VPVjDV8rsmkBKclQVHFkz8pwRUtE/view.

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

chore(deps): update golang version to v1.22.4 (go, golang)
chore(deps): update haproxy docker tag to v3

Detected dependencies

docker-compose

tests/integration/docker-compose.yml

haproxy 2.9

dockerfile

build/Dockerfile

golang 1.22.2-bookworm

tests/integration/Dockerfile

golang 1.22.2-bookworm

github-actions

.github/workflows/automated_release.yaml

newrelic/coreint-automation v3

.github/workflows/on_prerelease.yaml

newrelic/coreint-automation v3

.github/workflows/on_push_pr.yaml

newrelic/coreint-automation v3

.github/workflows/on_release.yaml

newrelic/coreint-automation v3

.github/workflows/repolinter.yml

newrelic/coreint-automation v3

.github/workflows/security.yaml

newrelic/coreint-automation v3

gomod

go.mod

go 1.22.2

github.com/newrelic/infra-integrations-sdk v3.8.2+incompatible

github.com/stretchr/testify v1.9.0

github.com/xeipuuv/gojsonschema v1.2.0

Check this box to trigger a request for Renovate to run again on this repository

newrelic / nri-haproxy Goto Github PK

nri-haproxy's Introduction

New Relic integration for HAProxy

Requirements

Installation and usage

Compatibility

Building

Testing

Support

Privacy

Contribute

License

nri-haproxy's People

Contributors

Stargazers

Watchers

Forkers

nri-haproxy's Issues

Description

Expected Behavior

Steps to Reproduce

Repolinter Report

Passed #

✅ license-file-exists #

✅ readme-file-exists #

✅ readme-starts-with-community-plus-header #

✅ readme-contains-link-to-security-policy #

✅ readme-contains-forum-topic #

✅ code-of-conduct-should-not-exist-here #

✅ third-party-notices-file-exists #

Repolinter Report

Fail #

❌ readme-starts-with-community-plus-header #

❌ code-of-conduct-file-does-not-exist #

Passed #

✅ license-file-exists #

✅ readme-file-exists #

✅ readme-contains-link-to-security-policy #

✅ readme-contains-discuss-topic #

✅ third-party-notices-file-exists #

Description

Description

Expected Behavior

Steps to Reproduce

Your Environment

Additional context

Description

Expected Behavior

Troubleshooting or NR Diag results

Steps to Reproduce

Your Environment

Additional context

For Maintainers Only or Hero Triaging this bug

Is your feature request related to a problem? Please describe.

Feature Description

Additional context

Priority

Repolinter Report

Passed #

✅ license-file-exists #

✅ readme-file-exists #

✅ readme-starts-with-community-plus-header #

✅ readme-contains-link-to-security-policy #

✅ readme-contains-discuss-topic #

✅ code-of-conduct-should-not-exist-here #

✅ third-party-notices-file-exists #

Repolinter Report

Passed #

✅ license-file-exists #

✅ readme-file-exists #

✅ readme-starts-with-community-plus-header #

✅ readme-contains-link-to-security-policy #

✅ readme-contains-discuss-topic #

✅ code-of-conduct-should-not-exist-here #

✅ third-party-notices-file-exists #

Open

Detected dependencies

Recommend Projects

Recommend Topics

Recommend Org

✅ `license-file-exists` #

✅ `readme-file-exists` #

✅ `readme-starts-with-community-plus-header` #

✅ `readme-contains-link-to-security-policy` #

✅ `readme-contains-forum-topic` #

✅ `code-of-conduct-should-not-exist-here` #

✅ `third-party-notices-file-exists` #

❌ `readme-starts-with-community-plus-header` #

❌ `code-of-conduct-file-does-not-exist` #

✅ `license-file-exists` #

✅ `readme-file-exists` #

✅ `readme-contains-link-to-security-policy` #

✅ `readme-contains-discuss-topic` #

✅ `third-party-notices-file-exists` #

✅ `license-file-exists` #

✅ `readme-file-exists` #

✅ `readme-starts-with-community-plus-header` #

✅ `readme-contains-link-to-security-policy` #

✅ `readme-contains-discuss-topic` #

✅ `code-of-conduct-should-not-exist-here` #

✅ `third-party-notices-file-exists` #

✅ `license-file-exists` #

✅ `readme-file-exists` #

✅ `readme-starts-with-community-plus-header` #

✅ `readme-contains-link-to-security-policy` #

✅ `readme-contains-discuss-topic` #

✅ `code-of-conduct-should-not-exist-here` #

✅ `third-party-notices-file-exists` #