newrelic / video-agent-ios Goto Github PK

The SDK should check/enforce that the underlying NR agent is not a deprecated type (<=7.0.0)

Please add SPM support - we have it already for newrelic-ios-agent-spm, so why not for video-agent-iOS also?

Thank you.

When there is an ad break, the content experiences a buffering cycle, that is labeled as bufferType = connection. We should check if there is an Ad running and set the bufferType as "ad".

[NSKeyValueObservance retain]: message sent to deallocated instance 0x165aa2fb0

scroll through a list of videos and have them start playing as they are brought up in the view port. We suspect it might have something to do with the observers not getting deallocated as we keep scrolling through videos. Our best guess is that the iOS agent was built primarily for a page view with only one video instead of a list of videos.

Upon heavy usage of our video data by building different dashboards with multiple widgets, we noticed that some of our events had no viewIds during ads.

After a bit of research, we stumbled upon this line in the library: https://github.com/newrelic/video-agent-iOS/blob/master/NewRelicVideoCore/NewRelicVideoCore/Tracker/NRVideoTracker.m#L148

The viewId is actually cleared on any AD_BREAK_* event, which kind of skew our data when playing around for widget related to ads.

What is the reasoning behind this approach? We noticed Android also doing it, but not Web.

Please note, I will enter the same issue in both repositories (iOS and Android).

366a1f7