nexdapp / nexd-ios Goto Github PK

Seems to be white text on white background:

Currently every time the HelperRequestOverviewViewController is opened a nes HelpList instance will be created for the currently logged in user. All requests which were added to previous help lists would be lost and never worked on - thats potentially evil.

A fix could be to check for any pending help lists, if there are any show a modal list to the user to chose which one he wants to continue working on and use that selected list instead of creating a new one.

To fix this issue we should check the GET /help-lists API if there are still active help lists for the current user. If yes then reuse that existing list, and prefill the "Accepted lists" section with all the requests from the unfinished list. Otherwise use the already existing logic and just start a new help list.

Default values of UITextField's autocapitalizationType, autocorrectionType and spellCheckingType values are not fitting to our implementation. It can cause some weird recommendations when users tries to write their names or email adresses for example.

Design has been reworked so it doesn't use as much space as it used to (to avoid necessity for scrolling in this screen). Check the figma design and adjust the implementation of MainPageViewController to match the design

Use a environment variable provided by CI (e.g. GITHUB_RUN_NUMBER ) as bundle short version (refer to https://help.github.com/en/actions/configuring-and-managing-workflows/using-environment-variables)

Registration screen scrolls to weird positions when the keyboard is appearing (as soon as the user taps on a textfield).

Technical info: For some newer screens (e.g. Transcribe*View.swift) I started to use Swiftui instead of Apple MVC. Moving this screen to SwiftUI to be able to reuse some of the .keyboard* helpers would definitely also be an option.

white text on white background:

https://www.nexd.app/privacypage

Buttons are covered by the iOS software keyboard:

On dark mode devices the text in text fields is white on light background and hardly visible

unnecessary need to scroll the screen because of that

UserDetailsViewController doesn't offer text fields for all information which can be sent to the PUT /users/me endpoint:

• add street
• add street number
• add city

Prefill the TextFields on the RequestConfirmationViewController with the contents of the own user profile information (GET /users/me - https://nexd-backend-staging.herokuapp.com/api/v1/docs/#/Users/UserController_findMe)

Add input validation to validate the stuff which is being entered by the user to match the backend requirements (phone number format etc)

Now that github allows private repositories also for organizations we can migrate the provisioning profiles used by fastlane match from my personal account to a private respository in NexdApp

UI Validation only checks for length of 3.

Even if a request has already finished the loading animation stays much longer

Replace red back/cancel buttons at the bottom of the screen with back buttons which are consistent with the ones implemented in issue #75 (dark blue in top left corner of the screen):

The audio players on the Transcribe*View.swift screens which are used to play back recorded calls cannot be listened to when the iPhone is switched to "Silent mode" with the hardware toggle (audio cannot be heard).

Probably the AVAudioSession needs to be properly configured in AudioPlayer.swift

Due to backend issue NexdApp/nexd-backend#73 the type of a help request cannot be determined so its hardcoded to "List" at the moment.

Once the backend provides this information the app needs to adapt the ui logic accordingly

This is how the information is supposed to be displayed to users (up to date specs can be found here: https://www.figma.com/file/QsK3lJrsgYLcFFIx49g23R/Nexd?node-id=552%3A45):

• rename git repository
• rename XCode Project
• fix name in Podfile

Without proper error handling in the view models HTTP errors can terminat subscriptions of the UI which leads wo weird user experience

• by default: only show help requests for the ZIP code from the user's profile
• add info text to the screen which tells the user that only help requests for zip code "12345" are shown
• when user taps the info add possibility to change ZIP code for the current search

REST API allows to specify the ZIP code as a query parameter

Use updated deployment at https://nexd-backend-staging.herokuapp.com/api/v1/docs/

Could potentially be re-added as soon as the hotline is getting better

Steps to reproduce

• register new user
• on "user details" screen right after registration kill the app and restart
  -> user can open the app without having accepted the privacy policy

In german "aufzuzeigen" is not correct translation. Use "aufzuzeichnen" instead (fix in poeditor, not in generated Localized.strings files):

Validation of the input form for user registration is based on old backend validation rules which are no longer valid.

The input validation for all text fields in user registration needs to be adapted to ne new validation rules of the backend:

• password length
• phone number format (backend uses libphonenumber for validation)

Use PUT /help-lists/{helpListId} to set a help list to completed once the user confirms he finished shopping (https://nexd-backend-staging.herokuapp.com/api/v1/docs/#/Help%20Lists/HelpListsController_updateHelpLists).

Issue occurred when switching from "prod" to "staging" backend:

• user was logged in on prod
• staging app was installed
• app tried to access backend with the "prod" account

Backend response for own profile was (but probably 401 should also be treated as unauthorized):

Status: 404, error: unsuccessfulHTTPStatusCode, data: {
    path = "/api/v1/users/me";
    statusCode = 404;
    timestamp = "2020-04-12T18:08:22.469Z";
}

This is how the app looks in this case (just empty, no error message):

To improve readability we should implement a "light mode" for the text input fields and add similar validation rules as we did for the registration screens, as they are currently hard to read and not validated at all:

In the HelperRequestOverviewViewController when the user taps one of the "other requests" open a subscreen which:

• shows all articles contained on that request
• shows a "Accept" button to actually add the list to "Accepted lists"

And when selecting entries from the "Accepted lists" open a subscreen which:

• shows all articles contained on that request
• shows a "Remove" button to remove the request from the help list

Currently it is not possible for a helper to check, resume or cancel previous help lists (i.e. "lists of requests he accepted previously").

We should add a button to the bottom of HelperRequestOverviewViewController which opens a screen where the user can browse his previous help lists:

This is how the button looks in android (uses string: helper_request_overview_button_previous_requests):

We should use "Duzen" instead of "Siezen" - go through all german texts and fix them (in PoEditor)

Seems like text is cut off after 2 lines:

• should be "Wie würden Sie gerne Ihre Liste erstellen?"
• but is cut off to "Wie würden Sie gerne Ihre Liste"

Add back button to screens as necessary. Design should look something like:

Latest design can be found here: https://www.figma.com/file/QsK3lJrsgYLcFFIx49g23R/Nexd?node-id=552%3A45

When you go to the second onboarding screen and re-run the app it automatically loggs you in instead bringing you back to the onboarding screens.

User profile screen should offer the possibility for the user to update all information wich can be updated with the endpoint PUT /users/me (refer to swagger docs: https://nexd-backend-staging.herokuapp.com/api/v1/docs/#/Users/UserController_updateMyself)

If the same article is contained on different help requests the shopping list should combine the requests and list the article only once and the article count should be the sum of all requests for that article