nexylan / paybox-direct Goto Github PK
View Code? Open in Web Editor NEWPaybox Direct and Paybox Direct Plus PHP SDK. Under development.
License: MIT License
Paybox Direct and Paybox Direct Plus PHP SDK. Under development.
License: MIT License
Implement psr/log
for logging.
See also how can we integrate it with monolog for Symfony projects.
Hello
Paybox' doc says that SITE, RANG and NUMQUESTION are always returned unchanged in the response, and their values must be the same than in the request.
Quote (sorry, french):
Les variables SITE, RANG et NUMQUESTION sont toujours répétées identiques à l’appel afin
de bien identifier à quoi correspond la question. Ces valeurs devront être contrôlées
systématiquement.
Source, page 12 : https://www.paybox.com/wp-content/uploads/2021/10/ManuelIntegrationVerifone_PayboxDirect_V8.2_FR.pdf
I suggest to introduce that check in order to consider a response valid or not.
Actually, this check is not possible outside the library, because the generated questionNumber
is private and incremented after each request.
The readme states 5.6 but composer says 7.4
Is 7.4 really needed or would it work fine on any 7.x?
Would expect backwards compatability to be possible with the right combination of dependency versions.
Or if not would you be open to me building a branch with full 7.x support?
If would be nice to be able to see the response object when an exception is displayed. Not sure if it should be part of the message or rather be a property of the exception, and have this property be nicely displayed by some framework integration class.
When logging the exception, this property should be added to the $context
argument.
On documentation, it says that DEVISE
is mandatory for some operation.
But if we try without this parameter (example: authorize
), this works.
Test:
Ref #12.
[Symfony\Component\DependencyInjection\Exception\RuntimeException]
Cannot autowire service "AppBundle\Manager\CreditCardManager": argument "$paybox" of method "__construct()" references class "Nexy\PayboxDirect\Paybox" but no such service exists. You should maybe alias this class to the existing "nexy_paybox_direct.sdk" service.
Try to remove magic calls on PayboxResponse
and do abstraction like on request classes.
Ref #12.
Those parameters would not exist on exception response.
paybox-direct/src/Response/DirectPlusResponse.php
Lines 36 to 37 in c987cf7
['PAYPAL', 'EMS', 'ATOSBE', 'BCMC', 'PSC', 'FINAREF', 'BUYSTER', '34ONEY']
And make PayboxException
heriting directly from \RuntimeException
.
Find a way to auto detect best http client to use if not provided and throw a proper exception if not found.
Link: https://github.com/greg0ire/enum
Discussion ref: #12 (comment)
If set to true
with production
flag also to true
, use the API_URL_RESCUE
as base url.
Affected people are probably not the same depending on the origin of the exception.
502
or maybe a 503
, beacuse it is probably an outage from payboxLikewise, error in code and validation problems should be segregated. Ideally validation problems should only happen on the merchant side, but it could happen further down the chain in case of suspicious activity of the cardholder, for example.
Here is how I organised that:
Exception
├── Error
│ ├── BankErrorException.php
│ ├── GatewayErrorException.php
│ └── MerchantErrorException.php
├── ErrorException.php
├── Validation
│ ├── BankValidationException.php
│ ├── GatewayValidationException.php
│ └── MerchantValidationException.php
├── ValidationException.php
├── Wallet
│ └── CardNotFoundException.php
└── WalletException.php
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.