GithubHelp home page GithubHelp logo

Comments (10)

kMutagene avatar kMutagene commented on July 4, 2024 1

As we discussed previously it was not clear if that term even has a specific position. However @HLWeil told me that it should always appear at the end of the contacts section, meaning it should follow Investigation Person Roles Term Source REF

from arctokenization.

kMutagene avatar kMutagene commented on July 4, 2024 1

Or maybe we give it follows to every other key in the Inv. Contacts section? @kMutagene

this is the worst imaginable solution, i would only implement that if we have no other choice

from arctokenization.

kMutagene avatar kMutagene commented on July 4, 2024 1

We invented the term in the sense that it is a mandatory line in our Investigation metadata files. Since we already "break" the pure ISA schema by requiring an optional field, we can also make sure to write it at a specific location to not make our lives miserable

from arctokenization.

kMutagene avatar kMutagene commented on July 4, 2024

should be fixed via 587eafb

from arctokenization.

HLWeil avatar HLWeil commented on July 4, 2024

@kMutagene, @omaus
Quick heads-up. The comments do not have to appear at a certain position within a section.
Just that our tools will put the comment at the end after read and write.

from arctokenization.

omaus avatar omaus commented on July 4, 2024

@kMutagene, @omaus Quick heads-up. The comments do not have to appear at a certain position within a section. Just that our tools will put the comment at the end after read and write.

I'd suggest to pin this at the specification because it's easier to test if it's always at the same position. Opinions? @HLWeil @kMutagene

Or maybe we give it follows to every other key in the Inv. Contacts section? @kMutagene

from arctokenization.

HLWeil avatar HLWeil commented on July 4, 2024

Well this is part of the standard ISA-Tab specification.
In general we definitely need some kind of ISA-XLSX specification. It's on my near-future bucket list.

from arctokenization.

omaus avatar omaus commented on July 4, 2024

Ok but would you rather suggest following the ISA-Tab specs or change this in our ISA-XLSX specs? @HLWeil

from arctokenization.

kMutagene avatar kMutagene commented on July 4, 2024

Since we invented this term and our tooling is the only source that writes this term, can we just use the convention of always writing this at a specific position to make our own lives easier? @HLWeil

from arctokenization.

HLWeil avatar HLWeil commented on July 4, 2024

Well, we didn't invent the isa comment "Comment". It is specified as followed in ISA-Tab:

Rows where the label Comment[<comment name>] appear can also appear within any of the section blocks. Where these appear, the comment name must be unique within the context of a single block (e.g. you cannot have multiple occurences of Comment[external DB REF] within STUDY ASSAYS. Also, the value cells MUST match the number of values indicated by the rest of the section in context.

So no constraint on any positioning in a section. Our tools follow this specification by reading anything that follows this specification and writing with the comments at the end of the section (just for ease of implementation).

Why should we constrain this, to allow comments only at the end?

from arctokenization.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.