ng2-ui / overlay Goto Github PK

Open wrong overlay because there is a duplicated id in the page.

Hi,

I'm having this issue when opening the overlay, some input and other components are not overlayed.

To test it:

Go to the demo and open the window overlay. A couple of buttons will be shown on top.

Using Chrome on Mac, but still reproducible with Safari and also with Chrome on Windows.

Thanks!

Regards

When using ngui/popup, the original web page can still be scrollable.
Is it possible to add this code when popup opened:
document.body.style.overflowY = 'hidden';
and add this code when popup closed:
document.body.style.overflowY = null;

I can't find the tests folder anywhere - neither on git or the node-module. Could you please provide an example of how to use this component?

The ng2-overlay component imports BrowserModule, this causes code that is built upon lazy loaded modules to fail with the following message:

EXCEPTION: Uncaught (in promise): Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.
Error: BrowserModule has already been loaded. If you need access to common directives such as NgIf and NgFor from a lazy loaded module, import CommonModule instead.

The import of the BrowserModule should be the responsibility to the base loader and not be done in a component like this. Please use CommonModule instead.

Can you add the src folder to the npm package on root level? The map files refers to this, but it doesn't exists, which renders the map files useless.

It would be nice if the overlay manager had a couple more methods:

1. isOpen(overlay) - to check if an overlay is open or closed
2. toggle(overlay) - opens the overlay if it is closed, and closes the overlay if it is open

I just tried to install on Angular 4 today and got this error:

frontend
├── UNMET PEER DEPENDENCY @angular/[email protected]
├── UNMET PEER DEPENDENCY @angular/[email protected]
└─┬ [email protected] 
  └── [email protected] 

npm WARN [email protected] requires a peer of @angular/core@^2.1.1 but none was installed.
npm WARN [email protected] requires a peer of @angular/common@^2.1.1 but none was installed.

Any chance Angular 4.0.0 support is coming? I don't know much about how this library works, but I can try to dig in later this week and test it out if that's helpful.