ngankhanh98 / coursebox-angular Goto Github PK

Issue type

I'm submitting a ... (check one with "x")

• bug report
• feature request
• question about the decisions made in the repository

Issue description

Current behavior:
Infinite loop update state with Observerable.subscribe()

Related code:

// auth.service.ts
this.user$.subscribe((user) => {
  const resetPwdToken: Partial<Auth> = {
    resetPwdToken: res['resetPwdToken'],
  };
  this.UPDATE_STATE(user.userId, resetPwdToken);
});

Issue type

I'm submitting a ... (check one with "x")

• bug report
• feature request
• question about the decisions made in the repository

Issue description

Current situation:
Currently, we have 2 big modules: pages and auth, each has their own Akita's state:

// auth.ts (state for AuthModule)
export interface Auth {
  username: string;
  fullname: string;
  userId: string;

  token: string;
}

// course.ts (state for PagesModule)
import { Auth } from 'app/auth/state/auth';

export interface Course {
  courseId: string;
  title: string;
  teacher: Auth;
}

Expected behavior:
In route: /attend/my-courses, I expect to see courses created by me. To doing so, auth.userId or auth.username should be retrieve; and course should returns to all course, then querying them both

Solution suggests:

1. Rewrite an api (GET - /course/{userId}), and maybe install another store state
2. Find the way to query the expected result from 2 store state using Akita query. In doing this, I found myself being confused about: where to install code properly, in my-courses.component.ts or in state/course.service.ts
   2.1. And do I have the kind of query allowing to use filter based on 2 Observerable (one with auth state, and the other with course state)?

__
Currently, I'm doging my 2nd approach. The above drawbacks are what I faced or am facing with. Besides, I would like to know if these 2 solutions are anti-pattern (because I have no idea).
@dohoangdinhtien

Issue type

I'm submitting a ... (check one with "x")

• bug report
• feature request
• question about the decisions made in the repository

Issue description

Current behavior: