nginxinc / nginx-for-azure-deploy-action Goto Github PK

Currently the shell script uses certain tools/mechanisms that are available on Ubuntu but may not be agnostic to other OS:

1.Tar - e.g. the path transform feature
2.UUID generation - for the suffix of the ARM template deployment name. We don't necessarily need to use UUID to ensure uniqueness of a template deployment name. A random string works equivalently.

It is desirable to make it more OS agnostic to faciliate local testing or workflow based on other OS images.

1. Give examples of configuring the action for using relative path VS absolute path.
2. Add links to the az login authentication action with different authentication mechanisms: service principal, federated credential

Currently the deployment script uses 6 positional arguments. The script is getting harder to use outside the context of a Github action.

As a best practice, we may want to consider usegetopts or another mechanism to make the parameters named. This would also make it easier to add additional input while keeping some optional.