Size not respected when [key] input changes about svg-icon

[NetanelBasal]

Do you want to create a PR? The issue is here

[RonnieRocket147]

Unfortunately I am too inexperienced to do this, however I can suggest the code change:

private fz: string = null;

...

if (changes.fontSize?.currentValue) {
  resolveFontSize = changes.fontSize.currentValue;
} else if (changes.size?.currentValue) {
  const size = changes.size.currentValue;
  resolveFontSize = this.mergedConfig.sizes[size];
} else if (this.fz !== null) {
  resolveFontSize = this.fz;
} else {
  const size = this.mergedConfig.defaultSize;
  if (size) {
    resolveFontSize = this.mergedConfig.sizes[size];
  }
}

[NetanelBasal]

I just tested it and it works fine.

[NetanelBasal]

Try to reproduce it on stackblitz, please.

[RonnieRocket147]

https://stackblitz.com/edit/angular-jqiivv?file=src/app/app.component.ts

[NetanelBasal]

Ok so that was the case on my side: https://stackblitz.com/edit/angular-ylikhn?file=src%2Fapp%2Fapp.module.ts

That's why it important to reproduce :)

[RonnieRocket147]

You forgot to define the default md size in the config. Then it will not change back to the default size indeed.

[NetanelBasal]

Try 2.1.1

[RonnieRocket147]

It works 2 times now, but then it fails again. See my stackblitz.

[RonnieRocket147]

resolveFontSize will be set to undefined after the first change. Then the next change it will revert back to default size. I guess my proposed fix will work.

Or add a final else clause to avoid setting this.fz to undefined again:

} else if (!this.fz) {
  const size = this.mergedConfig.defaultSize;
  if (size) {
    resolveFontSize = this.mergedConfig.sizes[size];
  }
} else {
  // No change in the already defined font size
  return;
}

[NetanelBasal]

Sorry, I'm not in focus. Try 2.1.2

[RonnieRocket147]

And fixed 😃 Thanks for your help and happy 2021!