GithubHelp home page GithubHelp logo

merge action can not work. about core HOT 5 CLOSED

ngx-rocket avatar ngx-rocket commented on June 19, 2024
merge action can not work.

from core.

Comments (5)

snowyu avatar snowyu commented on June 19, 2024

I have to use the writing event to manual merge deeply.

from core.

sinedied avatar sinedied commented on June 19, 2024

I just tested with your repo and commented the writing method in the branch you specified, and it worked as expected merging the package.json file?

Be careful when overriding base generator methods (prompting and writing) as you need to call the original method with super.<method> to make sure the original behaviors still works.
I'll add a note on the docs about this.

from core.

snowyu avatar snowyu commented on June 19, 2024

It's worked well after removing writing method.

But super.writing() in writing method only, It reports a confiction:

 conflict package.json

from core.

sinedied avatar sinedied commented on June 19, 2024

The original writing() method returns a promise, so you need to return it to make it work correctly:

writing() {
   return super.writing();
}

Should work the same as without the method

from core.

snowyu avatar snowyu commented on June 19, 2024

yeah, I did not expect the result to be a promise.

from core.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.