nhaehnle / less Goto Github PK

The command less skips the variables LESS_TERMCAP_* defined in the lesskey file (e.g. ~/.less).

This is because, the function main() retrieves the variables LESS_TERMCAP_*
before loading of the lesskey file. I propose to just invert two lines.

I explain that in details on this site:
https://unix.stackexchange.com/a/377221/13999

This is the current source code at line 110 in main.c

/*
 * Process command line arguments and LESS environment arguments.
 * Command line arguments override environment arguments.
 */
is_tty = isatty(1);
get_term();
init_cmds();
init_charset();
init_line();

This is the fix I have validated on my computer:

/*
 * Process command line arguments and LESS environment arguments.
 * Command line arguments override environment arguments.
 */
is_tty = isatty(1);
init_cmds();         /* Load lesskey file before */
get_term();          /* getting variables LESS_TERMCAP_* */
init_charset();
init_line();

I have just inverted two lines: get_term(); and init_cmds();

Questions:

• Do you want a pull request ?
• Do you want to follow bug-fixes from upstream project ?

For information I have sent the same bug report a fix proposal to the less mainteners.