nicolaspetton / amd-mode.el Goto Github PK

There exist at least 69 packages that contain a file named test-helper.el that also provides the feature test-helper.

This leads to issues for users who have at least two of these packages installed. It is unlikely that such a user would be able to run the tests of all of those packages. If the primary test file of one of those packages does (require 'test-helper), then it is undefined which of the various test-helper.el files gets loaded. Which it is, depends on the order of the load-path.

To avoid this conflicts, you should rename your test-helper.el to <your-package>-test-helper.el and adjust the feature and symbol prefixes accordingly.

Also don't forget to update the require form in your primary test file and/or update references to the library/feature elsewhere. Also, if your primary test file is named something like test.el, then please consider renaming that too (same for any other utility elisp files your repositoroy may contain).

Thanks!

PS: This issue is a bit generic because I had to open 69 issues.

After doing amd-find-module-at-point, xref-pop-marker-stack does not go back.

define([
    "src/animal"
], function(animal) {
    var rantamplan = animal({name: "milou"});

    rantamplan.say();
});

You will get unbalanced parenthesis.

Can I please have write access on the repo?

This change doesn't work with current stable version of projectile:

@@ -237,7 +237,7 @@ Also appends the filename to the modules list."
     (let ((file (projectile-completing-read
                  "Import file: "
                  (projectile-current-project-files)
-                 (concat (symbol-name (symbol-at-point)) ".js"))))
+                 :initial-input (concat (symbol-name (symbol-at-point)) ".js"))))
       (amd--import file))))
 
 (defun amd-rename-file ()
@@ -517,7 +517,7 @@ Note: This function is mostly a copy/paste from
   (let ((file (projectile-completing-read
                 "Find file: "
                 (projectile-current-project-files)
-                (concat name ".js"))))
+                :initial-input (concat name ".js"))))
     (find-file (expand-file-name file (projectile-project-root)))
     (run-hooks 'projectile-find-file-hook)))