markdown-parser's People
Forkers
will-hsu sywong888 vtdangg jesslam948 kaileywong molan0426 summerschulte stevo0718 nbilog smhitle natsukiromero satomitheito jisolpark kec020 thanhnhanlam cbcielo tcarman crustaceanking rudra17381 vatsalbagri1102 kunwang0129 bellareal jadechng ednavho cash-r w1caoucsd oxojasvixo kuangyuzou yuxinguo13 solitar7 nlchung9 mtonsing j02ephlee helloitsmurph ayditore ericsun153 angelsofttoy elaine-ch cathyiic potato0112 djun06 danielmilesgh doublealiu smallinaucsd rar001 paullai1022 jl-young reisandylamdjani johnpaulonza yeh0903 stevenzhuqy miyuki-l bhakin char15xu acandrad gmantuhac cynthia-bao seb-mejia cerealb andyfeng233 hdpham22 dklopstein kevinhu27 jerrylove77 brian-schodorf ritvikpen akann0 tkiyohar ahewig aejiang jerrik0 angeliazddl murph77 tomlandhilarious wanyingxu666 trinnnn sidbagdi adironene ryanyychen astrowang0306 nquach1515 kryptix3k mwchen25 mikayladalton2 lsa1to ddavevo zettabytescode allkeng tyler-culp minjismin katrinado ant0177 titan2142 thetalan rasika511 sgjr247 ezh247467 ivan-r-bs toomuchfish cbaeucsdmarkdown-parser's Issues
Lab Report 5 Feedback
Fails image test
If there is an exclamation point before the brackets, it will still consider it a link when it should consider it an image.
![not a link](something.url)
Failed Test Case
Lab Report 3 Feedback
Here is your feedback for Lab Report 3:
- Correct markdown formatting.
- Lab report is on its own page, not the index page.
- Correct screenshot of .ssh/config file
- Show the ssh command logging you into your account using just the alias you chose.
- Show an scp command copying a file to your account using just the alias you chose.
- Correct description of streamlining ssh configuration.
- Screenshot of where the public key you made is stored on Github and in your user account.
- Screenshot of where the private key you made is stored on your user account.
- Show git commands to commit/push a change while logged into your ieng6 account.
- Show a link for the resulting commit.
- Correct description of setting up Github access from ieng6.
- Show copying your whole markdown-parse directory to your ieng6 account.
- Show logging into your ieng6 account and compiling/running the tests for your repository.
- Show combining scp, semicolon, and ssh to copy the whole directory and run the tests in one line.
- Correct description of copying whole directories.
Additional comments from your grader:
Add comments on how/why these tasks worked.
If you don't have all the checkmarks above, fix the issues described, and then submit a regrade request on Gradescope. Use this template for your regrade request:
- Link to this issue
- Link to your published lab report page
.
Clean Up Comments
markdown-parser/MarkdownParse.java
Line 67 in 8dd87e6
Our suggestion:
“the close paren we need may not be the next one in the file” sounds really vague. We think this is potentially misinformation. We believe this can be more clearly stated as “the closing parenthesis may not be the next character that exists after the link, therefore we need to call the findCloseParen method to make sure”.
Clean Up Variable Naming
markdown-parser/MarkdownParse.java
Line 41 in 8dd87e6
markdown-parser/MarkdownParse.java
Line 52 in 8dd87e6
Our suggestion:
p
can be better named as filePath
to make it informative.toReturn
can be better named as linksFound
.Fails two tests
Test 1:
[](a link on the first line) [
[link?] actually never mind. (baited)
Failed some tests
Failed the test below:
testNoParantheses.md:
[test]]
@test
public void TestLinksNoParantheses()throws IOException{
content = Files.readString(Path.of("testNoParantheses.md"));
ArrayList links = MarkdownParse.getLinks(content);
assertEquals("tests if the links are the same", 0, links.size());
This part could be changed: https://github.com/Hiro-229/markdown-parser/blob/00ef25d341507df69fcacf50965823332b279ede/MarkdownParse.java#L30-L37
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.