nighoggdatatype / pe Goto Github PK

Currently, the return command requires the prefix bc/ behind the bar code of the book being returned. Assuming that only one bar code should be entered at a time, we can remove this redundant prefix and just directly enter the barcode. Eg: return 1234567890.

To recreate:

• Start a fresh copy of the software with default data
• Run borrow r/Alex Yu bc/1999999999 bc/1999999998

Expected Results: Rejected for inputting too many barcodes

Actual Results: Accepts, and silently only process the last barcode. This behaviour can lead to much confusion and mistracking.

This scenario in particular is a reasonable expectation of the borrow command, but can be worked around if caught on time, resulting in the medium rating.

I currently assume that the late fees are calculated on a hourly basis based on this screenshot:

Currently, there is no way to set a custom rate via a stand alone function.

Even if there is, as a hidden feature in one of the config files, it is not stated in the User Guide, and if it is in one of the other commands, then it would be placed wildly inappropriately.

I rate this of high importance since this is a matter of money, which might make it useless to determine late fees.

It is known from the user guide that readers cannot be deleted if they still have borrowed books. This is not reflected in the use case.

Steps to recreate:

• Start out with the default data.
• Execute the command: return return bc/1000000000 bc/1000000001
  • This corresponds to "The Hobbit" and "The Old Man And The Sea", both borrowed by "Bernice Tan"
• Observe that rather than be rejected, as expected from the command format return bc/BARCODE it is instead accepted.
  • Also note that only one of them is accepted, which can cause confusion, since the success of the operation gives the impression that both are accepted.

Below is the documentation for return.

The picture for the GUI should ideally have all of the major sections labeled, since it is not clear what is for text entry, and what is for text output for starters.

UML diagram could do to include what function is running in the ReturnCommand object

Nowhere in the UG is it stated when a book is considered overdue. Is it hard-coded, or can it be customized in some setting somewhere, or could it be different between users, perhaps with longer registered, and higher activity borrowers being more trustworthy of longer borrowing times?

There is currently no command explicitly to set the default time until a book is considered overdue.

There is also no known feature to set any sort of deadline for a book to be returned by, so it is likely hard coded as far as I can tell.

If such a feature does exist, it is already too difficult to discover, since if it is neither a stand-alone command, or part of the 'borrow' command, or part of a non-existant 'settings' command, there are no more obvious places to set it.

It is unclear what the late return fee is if a book is returned late, or how it is calculated. I rate it of high severity since money matters should not be left clear, and this is a likely cause for disputes.

"The user inferface must be intuitive and clear, so that new users can use the app without
much difficulty."

It is unclear what counts as intuitive and clear, since this is a subjective evaluation. A better metric would be that "New users can complete the following X tasks within 2 hours of first learning about the product, with reading the UG included in the timing"

This UML diagram is entirely too detailed to be read easily.
This needs the PDF reader to be zoomed in almost entirely on the diagram to read it properly.

Suggestion, break this diagram down into multiple, simpler diagrams.

To recreate:

• Start up a fresh copy of the software with default data
• Run: borrow r/Irfan Ibrahim bc/1999999995 r/Roy Balakrishnan

Expected behavior: Rejected for having too many readers

Actual behavior: Silently accepts, and gives the book to the last input-ed user.

While the general gist is understood, some details are missing that should have been included.

Namely, the check for whether a book is still being borrowed is missing.