night-sky-studio / ibuki-mobile Goto Github PK

The problem

Currently the download button in ImageViewer does not display progress nor any status of what has happened with the download itself.

The purposed solution

Add some kind of indication (CircularProgressBar/Icon) to display the status of current download state.
We already have a function for tracking progress, we need to have a hook that'd change download button's contents depending on the status.

/// lib/pages/image_viewer_page.dart:90
await Dio(BaseOptions(headers: {"User-Agent": "IbukiMobile/1.0.0 Ibuki/1.0.0 (Night Sky Studio)"})).download(
    image.originalFileURL, 
    savePath,
    onReceiveProgress: (received, total) {
        if (total != -1) {
            debugPrint("${(received / total * 100).toStringAsFixed(0)}%");
            //you can build progressbar feature too
        }
    }
);

The problem

Today's update brought issue with pages again: now results in searrch, etc. are being displayed twice.

The problem

Currently, if bottom pane contents in ImageViewerPage can scroll, then SingleChildScrollView overrides scrolling behavior of the Pane and there is no way to close it, unless you grab the header, which is not the part of a scroll view mentioned above.

Expected behavior

Panel closes regardless of its contents when user swipes down on it.

Device information

All platforms

Additional context

Looks like we'd need to wait for the SlidingUpPanel to be updated or find our own solution, because using provided ScrollController does fix the issue, but messes up pagination...

The problem

On Android API 33 the application does not start, because it tries to ask for permissions there and fails.

/// lib/main.dart
if (Platform.isAndroid) {
    Map<Permission, PermissionStatus> statuses = await [
        Permission.storage,
        //add more permission to request here.
    ].request();

    if (!statuses[Permission.storage]!.isGranted) {
        debugPrint("Permission denied.");
        exit(1);
    }
}

Purposed fix

Check if the current API level is less than 33 and ignore asking for storage permissions there.