GithubHelp home page GithubHelp logo

Comments (5)

NightFright2k19 avatar NightFright2k19 commented on May 25, 2024

I would need a screenshot for this. Note that most of these sprite alignments weren't made by me, but the actual sprite artists who added the widescreen extensions. It should be assumed all alignments are correct, especially nobody has ever complained about them in years. It's kinda hard for me to believe something has been overlooked after all.

(Unless I misunderstand this and it's about a visual flaw on the actual sprite, something that would need to be done with an image editor.)

from duke3d_widefix.

FistsAkimbo avatar FistsAkimbo commented on May 25, 2024

Sure thing, I attached the pictures below.

To clarify, I'm not referring to your mod's position of the sprites (which appear to drop the top layer of the freezethrower in the same offset position as the original DN3D) but how in both cases, they aren't being drawn correctly based off of position; for all three upper sprites used in the animation, they're all offset to the right by three, and down by seven.

video screenshot
freezethrower misaligned 1
freezethrower misaligned 2
freezethrower misaligned 3
freezethrower correct 1
freezethrower correct 2
freezethrower correct 3

from duke3d_widefix.

NightFright2k19 avatar NightFright2k19 commented on May 25, 2024

I see what you mean. Please test with the attached test file and report back whether alignments are correct now. Since the lower part seems to be properly in place, I have adjusted the top part of the gun (tiles 2551-2553).

In fact, technically all default alignments are correct since they follow the DOS release. It's the replication of a bug in the original game. Which doesn't mean it shouldn't be addressed, but in the end it's hard to tell which kind of correction is better. Possibly adjusting the top part.

Also:
I assume the Caribbean counterpart of the Freezer does not require these adjustments. I have checked it ingame and it looks as intended with its current settings.

duke3d_widefix-test.zip

from duke3d_widefix.

FistsAkimbo avatar FistsAkimbo commented on May 25, 2024

Thanks for that test zip, the alignment is right on the money. However; just like 20th Anniversary World Tour (which also fixes the freezethrower offsets,) there's this bizarre small gap seen in the animations while it's firing, where I'm not sure if it's just how these sprites are drawn by the renderer, or if it's somehow an offset error. I lean towards the former because, every time I stopped mid-firing frame by opening the main menu, the sprites are drawn correctly with no gap, when the display of the game is at a rest. I've included a minor edit that extends the bottom cutoff edge of the base sprite so that it may save you half a minute to edit. But of course, if there's some other proper means of fixing this strange gap, that should probably be the way to go.
2550 inner edge extended
duke0018

from duke3d_widefix.

NightFright2k19 avatar NightFright2k19 commented on May 25, 2024

I have integrated your fix on Github. It will be in the next release.

from duke3d_widefix.

Related Issues (8)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.