niinpatel / calculator-react Goto Github PK

I'm getting a this.reset is not a function and eval can be harmful error when I rewrite your code. Can you fix it.

I see there is some small structuring problem in your code. like extra white space, too many if else(not a good practice). I can fix these issues for you. Should I do it?

If the input has parenthesis without multiplying sign (*) an error is printed.

Example:
2(2) -> error
2*(2) -> 4

It is pretty basic to use parenthesis without multiplying sign, so the calculator should handle this.

If you put two minuses in a row you'll get an error.

For example: 1--1 should be 2. Instead the result is an error.

1-(-1) results to 2 instead, so that is working as expected.

I consider this a bug, because you shouldn't rely on user going through the trouble of always placing the parentheses. Also, I think it's very common for calculators to handle two minuses in a row.

I cloned the repo and got 1 mb of size. After npm install I got 200 mb. Is this the wanted behaviour or should I investigate further because of a bug? Thanks.