GithubHelp home page GithubHelp logo

ember-cli-bem's Issues

Missing module ember-get-config

After updating to v1.0.0-beta.1 i get the following error:
Error: Could not find module 'ember-get-config' imported from 'ember-cli-bem/mixins/bem'

Suggestion rename helper from "elem" to "bem"

Hi, looks like a great plugin thanks!

I think the elem helper would probably be better if called bem instead, because elem is very generic. It is less likely to collide with other helpers and easier to understand what it is doing.

Edit: Might also be a good idea to rename mods to bemMods.

Just a suggestion, thanks for reading!

Custom Delimiters in v1.0.0-beta.1+

Using custom delimiters (elemDelimiter and modDelimiter) only work in v1.0.0-beta.1+

When downloading via Installation heading in the readme (ember install ember-cli-bem), it only downloads the latest stable, which as of this writing does not include the custom delimiters.

Either update the readme to include a note about custom delimiter option is only available in v1.0.0-beta.1+, or create a new release so users can use it when running the ember install command.

PS: Great job on this, I knew there had to be a better way instead of using {{concat cssClassName "__element"}} everywhere, lol!

Minimum supported Ember version

What is the minimum supported Ember version? I tried to use this addon with Ember 1.12.2 but seems it doesn't work.

It would be nice to add the info about minimum version to Readme.

Block-scoped declarations in lib/htmlbars-plugin.js

After installing ember-cli-bem plugin I get the following error during build:
Block-scoped declarations (let, const, function, class) not yet supported outside strict mode

which is caused by the file in the subject. Could you please add 'use strict'; to the top of the file? I know this error will be gone once I upgrade node but right now in our corporate development environment we are using v4.8.0 and it's not gonna change in the nearest future.

Looks like a minor change...

Use BEM modifier syntax

Hey, why do you use one underscore instead of the two dashes for the modifier?

Your naming:
button__container_collapsed

BEM naming:
button__container--collapsed

Accessing a component with BEM mixin in Ember inspector causes ember inspector to crash

When I try and load up a component in the Ember inspector that has the ember-cli-bem/mixins/bem applied to it, it causes the Ember inspector to error out with the following in the console:

VM38853:92 Ember Inspector has errored.
This is likely a bug in the inspector itself.
You can report bugs at https://github.com/emberjs/ember-inspector.
Error message: Assertion Failed: You attempted to access `modsClassNames.type` (on `<ceannate-web@component:consent-documents/document-list::ember1447>`), but `modsClassNames` is a computed property.

Due to certain internal implementation details of Ember, the `modsClassNames` property previously contained a private "descriptor" object, therefore `modsClassNames.type` would have been `undefined`.

This implementation detail has now changed and the "descriptor" object is no longer present at this location. Soon, accessing `modsClassNames` on this object will return the computed property's current value (see RFC #281 for more details).

If you are seeing this error, you are likely using an addon that relies on this now-defunct private implementation detail. If you can, identify the addon from the stack trace below and report this bug to the addon authors. If you feel stuck, the Ember Community Slack (https://ember-community-slackin.herokuapp.com/) may be able to offer some help.

If you are an addon author and need help transitioning your code, please get in touch in the #dev-ember channel in the Ember Community Slack.
Stack trace: Error: Assertion Failed: You attempted to access `modsClassNames.type` (on `<ceannate-web@component:consent-documents/document-list::ember1447>`), but `modsClassNames` is a computed property.

Due to certain internal implementation details of Ember, the `modsClassNames` property previously contained a private "descriptor" object, therefore `modsClassNames.type` would have been `undefined`.

This implementation detail has now changed and the "descriptor" object is no longer present at this location. Soon, accessing `modsClassNames` on this object will return the computed property's current value (see RFC #281 for more details).

If you are seeing this error, you are likely using an addon that relies on this now-defunct private implementation detail. If you can, identify the addon from the stack trace below and report this bug to the addon authors. If you feel stuck, the Ember Community Slack (https://ember-community-slackin.herokuapp.com/) may be able to offer some help.

If you are an addon author and need help transitioning your code, please get in touch in the #dev-ember channel in the Ember Community Slack.
    at new EmberError (http://localhost:4200/assets/vendor.js:28634:25)
    at Object.assert (http://localhost:4200/assets/vendor.js:28877:15)
    at Object.get (http://localhost:4200/assets/vendor.js:38317:42)
    at addProperties (<anonymous>:3106:40)
    at mixin.mixins.forEach.mixin (<anonymous>:3077:11)
    at Array.forEach (<anonymous>)
    at propertiesForMixin (<anonymous>:3075:20)
    at Class.mixinsForObject (<anonymous>:2965:22)
    at Class.sendObject (<anonymous>:2884:26)
    at Class.inspectById (<anonymous>:2808:16)

Any ideas as to how I could refactor the library to play nicely with the latest Ember Inspector?

Here's what I'm currently running:

Ember Inspector | 3.3.2
Ember | 3.0.0
Ember Data | 3.0.2

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.