niklasberlin / midicraft_extended_led_feedback Goto Github PK

Plugin terminates when using the color violet on a page:

Does this plugin support feedback for electric thrusters? I hope to update the feedback for thrusters and push rods

When using the page change functionality changing pages fast could lead to undefined states of LED behavior from which the plugin does not recover until the update due to page change or timer.

It might be wise to lock the update on the page change routine for the time the plugin needs to perform an update. This way the plugin lags if pages are changed fast but it does not enter an undefined state.

This can be done by setting a flag once the plugin performs an export/update that is only cleared after all the data has successfully been processed.

The update on the page change routine then checks that flag before it performs another update.

To reduce the time the plugin needs to perform a full update cycle the plugin could check if an LED needs to be updated by tracking the states internally and only outputting the midi values needed to make the controller's appearance match the MA2 appearance.

For this, it's needed to track the LED states in a new array and check the results coming from the appearance import against that array only outputting midi data for the values that don't match anymore. After outputting the midi data the array is also updated with the changes.

hey,
it would be nice if a license was added to this repo that way the code can be used.