nikrimington / hotchilli.umbraco.pagenotfoundmanager

V9 version of PageNotFoundManager

hotchilli.umbraco.pagenotfoundmanager's Issues

Menu item shows on all context menus

Version
Umbraco V9 RC3

Issue
The "Manage 404 Page" menu item is showing on all context menus

Expected
The "Manage 404 Page" menu item should only show on the "Content" context menu

Package causing issues on Umbraco Cloud

Umb V10.5.1 on Umbraco Cloud

Uploaded code to Umbraco Cloud to a site that had been running with the package for ages. The new code was a Vendr installation. On restart the site gave the following error: "ArgumentOutOfRangeException: StartIndex cannot be less than zero. (Parameter 'startIndex')" Start of Discord discussion here: https://discord.com/channels/869656431308189746/882984067312787466/1123268526229180496

Thread here: https://discord.com/channels/869656431308189746/882984067312787466/1123904588261621800

Message with pointer to actual code here: https://discord.com/channels/869656431308189746/1123904588261621800/1123964077086097461

Only mitigation was to remove package as advised.

Feature: Integrate with Usage Tracker in Umbraco

Update the process when adding/removing Page Not Found pages to add a relation into the Usage Tracker relations so that editors know if they remove a page that is being used as a 404.

The icon in the context menu seems like something is wrong

The icon in the context menu seems like something is wrong with this option.
Maybe this can be a less "aggressive" icon? Or is there a reason for being a warning icon?

Feature: Overarching Dashboard View

Add a Dashboard to show all the configured 404's

This should also highlight where the 404 page that was picked no longer exists, or the parent page no longer exists to allow for Database Cleanup.

Ok button doesn't seem to do anything

On the confirmation screen after setting the not found page, the Ok button doesn't close the blade.

Investigate: Is is possible to use this product to define the 404 page for Media / Static assets

It would be great if a media/static asset 404 could be picked/configured in a similar approach as Content is.

This might be a completely mad idea, so just after some thoughts on this at this stage.

Accidentally removes setting, if a 404 page is already set

Not sure how to describe this perfectly but was testing out the package on the starter kit and had set the 404 page for the home page to a page. When opening the 404-page dialog afterwards, it looked broken, and I couldn't select a 404 page, I only had the one chosen available, but I couldn't even select that one.

Upon clicking ok, the 404-page setting got removed. I've recorded a gif of it:

Having issues in a sub-folder tree structure

Was so glad to see an U10 supported version of this package available as I've used it in previous V7/V8 sites.

However I've installed the package in my Umbraco v10.4.0 site which runs as a Windows x64 Azure App Service and I've got the context menu allowing me to pick my 404 pages but the 404 is still directing me to the first root node 404 page?

Current Tree Structure:

I will say that until I found this version of the package, I had a custom 404 page configure in my AppSettings.json files but I've gone through and removed that key from all appsettings.json files (Development, Production etc) fully published and restarted the site but still seeing the same behaviour. Is the above content tree supported and maybe I'm just missing something?

Update from v2.0.0 to 2.1.0 causes BootFailedException: "Conflicting routes, you cannot have multiple controllers with the same name: MenuController"

Just updated this via NuGet and now get this error:

BootFailedException: Boot failed: Umbraco cannot run. See Umbraco's log file for more details. -> Umbraco.Cms.Core.Exceptions.BootFailedException: Conflicting routes, you cannot have multiple controllers with the same name: MenuController

Reverting the update resolves the issue.

Info:

Umbraco version 10.2.1

All packages installed:

	<PackageReference Include="Cultiv.EnvironmentInspect" Version="1.0.1" />
	<PackageReference Include="Dawoe.OEmbedPickerPropertyEditor" Version="10.0.0" />
	<PackageReference Include="Dawoe.OEmbedPickerPropertyEditor.Core" Version="10.0.0" />
	<PackageReference Include="Diplo.GodMode" Version="10.2.0" />
	<PackageReference Include="Dragonfly.Umbraco10.Forms.Web" Version="0.0.17" />
	<PackageReference Include="Dragonfly.Umbraco10.SchemaImporter" Version="0.2.0" />
	<PackageReference Include="Dragonfly.Umbraco10.SiteAuditor" Version="0.0.2" />
	<PackageReference Include="Dragonfly.Umbraco10.Theming.Web" Version="0.2.3" />
	<PackageReference Include="HotChilli.Umbraco.PageNotFound" Version="2.0.0" />
	<PackageReference Include="Limbo.Umbraco.ModelsBuilder" Version="2.0.0-alpha002" />
	<PackageReference Include="Our.Iconic" Version="4.0.0" />
	<PackageReference Include="Our.Umbraco.Community.Contentment" Version="4.1.5" />
	<PackageReference Include="Our.Umbraco.Community.Contentment.Core" Version="4.1.5" />
	<PackageReference Include="Our.Umbraco.SimpleTreeMenu" Version="3.0.0" />
	<PackageReference Include="Our.Umbraco.Skipper" Version="1.1.3" />
	<PackageReference Include="Umbraco.Cloud.Identity.Cms" Version="10.0.4" />
	<PackageReference Include="Umbraco.Cloud.StorageProviders.AzureBlob" Version="10.0.0" />
	<PackageReference Include="Umbraco.Cms" Version="10.2.1" />
	<PackageReference Include="Umbraco.Deploy.Cloud" Version="10.1.0" />
	<PackageReference Include="Umbraco.Deploy.Contrib" Version="10.1.0" />
	<PackageReference Include="Umbraco.Deploy.Forms" Version="10.1.0" />
	<PackageReference Include="Umbraco.Forms" Version="10.1.2" />

UPDATE: Improve the UI for picking / viewing the 404 page for a given node/area

The current UI, although functional, is a bit messy.

It would be great to have a new UI that allows for a page to be picked, or a picked page to be changed without having to remove and re-add.

Not supported in .Net 7.0

I use this package and try to upgrade Umbraco to 11+
But it seems to fail because this package is in .Net 6.0.
Will there be a new version of this that runs in .Net 7.0?

Upgrade from V8 to V9 throws an exception

When upgrading a site from V8 to V9 I got the following error:

[CI/CD] Get Github Actions Working Properly

Feature summary

I am after 2 Github Actions, or one clever one that can do multiple things depending on conditions.

Step 1 - Build and Package - this should run against every commit to develop or PR to develop to ensure that the code can be built and packaged.

Step 2 - if the action is triggered via a new Release/Tag it should do step 1 and then push to nuget.

Things to note:

Ideally the action would pick up the last version from the tags on the repo - tag standard should start with v and then be "semver" ish - e.g. v1.0.0

If the action is running only step 1, i.e. was triggered by a PR or a commit to develop, then it should increment the minor number for the last tag and add a -pre suffix using the build/run instance id so it's unique. This should be used during the build and packaging stage.

If the action is running because it was triggered by a tag, then the build and package part should use the new tag as the version number for build and packaging

Hopefully all makes sense

Additional details

No response

Improvement: When deleting a page delete associated PNF records

Currently if you deleted a page (removal from recycle bin) that has an associated Page Not Found record, that record persists, cluttering the database table.

We should remove PNF records for the current page, and for child pages.

Note: Integrating with the Usage tracker might help with this, so it's possible this could become unneccessary.