nimrodda / github-commit-browser Goto Github PK

Hi Nimrod,
I'm trying to add FragmentFactory to your example but I'm blocked in a circular dependency.

Usually constructor injected Fragments are like this when used with FragmentFactory

class Fragment @Inject constructor (
    private val viewModelFactory: ViewModelProvider.Factory
) : Fragment() { 
    private val viewModel: MyViewModel by viewModels { viewModelFactory }
}

The problem I have it's that now with the AssistedInjected ViewModelFactory my Fragment code should change to something like this:

class Fragment @Inject constructor (
    private val viewModelFactory: ViewModelFactory
) : Fragment() { 
    private val viewModel: MyViewModel by viewModels { viewModelFactory }
}

But here the circular dependency:
Fragment needs ViewModelFactory to be created ->
ViewModelFactory need a SavedStateRegistryOwner to be created ->
I can't create the Fragment to get one.

Do you have ideas on how this could be solved?
BTW Thank you for you article 👍

for viewmodels that are bound to navgraphs instead of activities or fragments, how do we create the savedstateRegistryOwner?

as below

@Binds
    abstract SavedStateRegistryOwner bindSavedStateRegistryOwner(CommitListFragment commitListFragment);

Hello @Nimrodda ,

I've the same DI setup as you, everything works like a charm, but I was wondering, what if we would like to dynamically put some values inside the bundle (from AbstractSavedStateViewModelFactory) to be used inside the ViewModel - let's say I want to catch something from getIntent() or getArguments() and forward it through the bundle - how would you implement it?

Thanks once again.