Logging occasional ConcurrentModificationException errors about android-permissions

[nishkarsh]

Hey @mikejeep! Fortunately, I was able to reproduce this issue and verify the fix with a unit test. You should upgrade the dependency to version 2.0.54 in which the issue is resolved. You should eventually stop seeing these errors from the users of your app.

Thanks again for reporting this!

[mikejeep]

Thank you @nishkarsh! I will update my app today and monitor the exception logging, once I'm confident it's no longer an issue I will close this issue out. I'd like to send you a contribution as thanks for your efforts if you could provide the preferred way to do that.

[mikejeep]

@nishkarsh I know you are busy, I just saw on another issue that you have taken donations in the past. I would be happy to make a contribution if that will help accelerate the resolution of this bug. I am logging a lot of these exceptions from my users and would like to resolve it.

[nishkarsh]

Hey @mikejeep, I will look into this one today. Other internal projects had been keeping me busy but it has been pending for way too long.

[christocracy]

@nishkarsh Probably related to not accessing stuff like pendingPermissionRequests within synchronized block, eg:

synchronized(pendingPermissionRequests) {
    pendingPermissionRequests.removeAll(asList(grantedPermissions));
    pendingPermissionRequests.removeAll(deniedPermissions.stripped());
    if (pendingPermissionRequests.isEmpty()) {
        manager.unregisterBroadcastReceiver();
    }
}

[mikejeep]

I edited my original comment with a better crash report that did not have any methods obfuscated.

[nishkarsh]

@mikejeep thanks for reporting this! @christocracy thanks for investigating it a bit!

I would be soon back to work from a short vacation and look into this! Perhaps a test would be able to reproduce this and verify the fix.

[christocracy]

A test to reproduce this will have multiple permission requests on different threads.

This is a multi-threading issue.

[mikejeep]

Any updates on this? Thanks!

[nishkarsh]

Unfortunately, I have not been able to spend time on this one yet. I would look into it ASAP.

[nishkarsh]

Yes, since the issue was at multiple places, give it some time in production to verify that all of those places have been patched.

You can now see a Sponser label in the menu on top in the repository that you could use to donate an amount of your choice. Thanks for supporting the library!

[mikejeep]

This appears to be resolved, the error reports have disappeared. I appreciate your time and going to go hit that Sponsor page now, thanks!