[Updated] The library is still a live!! thank you @nishkarsh about android-permissions

[nishkarsh]

Hey folks! I thought I would just pitch in to resolve this.

@mariopce thanks for creating this issue to create a sense of urgency to fix the original issue, though it could have been done by following up again on the original thread for the issue created. I still appreciate that you notified about the issue and you should absolutely continue to do so.

@christocracy I appreciate you participating in this thread and I think if we have to talk about the original issue here, that would be missing guidelines for contribution by others. I should probably mention some of the guidelines so that it's easier for other folks to contribute in a better way, including proper description and tests for any changes made.

Ultimately, I believe that any open source library/project would continue to exist only if the community contributes by raising issues, suggesting features and contributing actual code.

Thanks once again!

[mariopce]

Issue fixed the latest build updated. Thank you

[christocracy]

Looks like the library was abandoned by the creator. Don't use that!!

I suggest you edit the hysterical title of this issue. I've been using this library for over 3 years and @nishkarsh has been incredibly responsive to all my issues.

[mariopce]

Looks like the library was abandoned by the creator. Don't use that!!

I suggest you edit the hysterical title of this issue. I've been using this library for over 3 years and @nishkarsh has been incredibly responsive to all my issues.

Yeah, I apologize @nishkarsh I just see so many abandoned libraries where I find an issue I'm providing PR, and nobody accepts the PR for months.

[christocracy]

I too am a library maintainer. I maintain 12 public libraries. Your PR does not contain a description and the commit message is poor, says little more than "Fix issue with npe and update libs".

I wouldn't merge that either.

[mariopce]

I fixed the issue for the newest android-12 users and I thought that fix is extreamly important for users of that lib. If I was selfish developer I could just fork the repo and fix issue and don't share the message with others. From your message i think that could be better if i could don't share warnings. All dev should recognize idsue that the app fails by byself. I not sure what is better?

[mariopce]

Thank You @nishkarsh for your work. I'm grateful. Hope U are well