GithubHelp home page GithubHelp logo

nitish-kalan / cartpole-v1-advantage-actor-critic-a2c-keras Goto Github PK

View Code? Open in Web Editor NEW
3.0 1.0 4.0 482 KB

Solving CartPole-v1 environment in Keras with Advantage Actor Critic (A2C) algorithm an Deep Reinforcement Learning algorithm

Python 100.00%
reinforcement-learning reinforcement-learning-algorithms advantage-actor-critic cartpole-v1 cartpole-gamebot machine-learning actor-critic

cartpole-v1-advantage-actor-critic-a2c-keras's People

Contributors

nitish-kalan avatar

Stargazers

avatar avatar avatar

Watchers

avatar

Forkers

om-secadvice gabisurita michalogloza puyo1999

cartpole-v1-advantage-actor-critic-a2c-keras's Issues

cur_state inaccurate until MINIMUM_REPLAY_MEMORY is reached 

        if len(replay_memory) < MINIMUM_REPLAY_MEMORY:
            continue
        # Trinig actor and critic
        train_advantage_actor_critic(replay_memory, actor, critic)
        cur_state = next_state

Note that before the replay_memory reaches the threshold, cur_state is never updated, so the replay memory is flawed.

train_adv_actor_critic logic

Hi,

In the def train_adv_actor_critic function train.py file, when you randomly sample and train the actor with these samples (generated by different policies) isn't that essentially off policy? Whereas A2C is on policy algorithm.
Can you please clarify this and correct me if my understanding is wrong.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.